Expose Map/UnmapTexSubImage2DCHROMIUM to pepper plugins

Expose Map/UnmapTexSubImage2DCHROMIUM to pepper plugins

This is done as a separate interface, but similar to PPB_OpenGLES2_Dev

BUG=none
TEST=With Flash

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70706

[piman, 2011-01-06 03:58:22]

I don't have a good name for the interface... Open to anything.

[apatrick, 2011-01-06 16:50:29]

Drive by...

http://codereview.chromium.org/6080012/diff/1/ppapi/c/dev/ppb_gles_chromium_e...
File ppapi/c/dev/ppb_gles_chromium_extension_dev.h (right):

http://codereview.chromium.org/6080012/diff/1/ppapi/c/dev/ppb_gles_chromium_e...
ppapi/c/dev/ppb_gles_chromium_extension_dev.h:13: struct
PPB_GLESChromiumExtension_Dev {
There will be other CHROMIUM extensions in the future and we'll want a separate
PPAPI interface for each of them. Perhaps name this after the feature it
provides, i.e. mapping and unmapping a texture?

http://codereview.chromium.org/6080012/diff/1/webkit/plugins/ppapi/ppb_gles_c...
File webkit/plugins/ppapi/ppb_gles_chromium_extension_impl.cc (right):

http://codereview.chromium.org/6080012/diff/1/webkit/plugins/ppapi/ppb_gles_c...
webkit/plugins/ppapi/ppb_gles_chromium_extension_impl.cc:5: // This file is
auto-generated. DO NOT EDIT!
Are the changes to the python script that generate this file in another
changelist?

[brettw, 2011-01-06 17:58:23]

http://codereview.chromium.org/6080012/diff/1/ppapi/c/dev/ppb_gles_chromium_e...
File ppapi/c/dev/ppb_gles_chromium_extension_dev.h (right):

http://codereview.chromium.org/6080012/diff/1/ppapi/c/dev/ppb_gles_chromium_e...
ppapi/c/dev/ppb_gles_chromium_extension_dev.h:14: void*
(*MapTexSubImage2DCHROMIUM)(
I don't quite get the naming convention. Why do we need CHROMIUM in all caps at
the end of each of these functions? It might also be nice to have some
documentation, even if brief (and mentioning that you should unmap it).

http://codereview.chromium.org/6080012/diff/1/webkit/plugins/ppapi/ppb_gles_c...
File webkit/plugins/ppapi/ppb_gles_chromium_extension_impl.cc (right):

http://codereview.chromium.org/6080012/diff/1/webkit/plugins/ppapi/ppb_gles_c...
webkit/plugins/ppapi/ppb_gles_chromium_extension_impl.cc:19: PP_Resource
context_id,
Should be indented 4 spaces.

[piman, 2011-01-06 22:31:12]

http://codereview.chromium.org/6080012/diff/1/ppapi/c/dev/ppb_gles_chromium_e...
File ppapi/c/dev/ppb_gles_chromium_extension_dev.h (right):

http://codereview.chromium.org/6080012/diff/1/ppapi/c/dev/ppb_gles_chromium_e...
ppapi/c/dev/ppb_gles_chromium_extension_dev.h:13: struct
PPB_GLESChromiumExtension_Dev {
On 2011/01/06 16:50:30, apatrick wrote:
> There will be other CHROMIUM extensions in the future and we'll want a
separate
> PPAPI interface for each of them. Perhaps name this after the feature it
> provides, i.e. mapping and unmapping a texture?

Done. I called it ChromiumTextureMapping (under the assumption that the
extension would be called GL_CHROMIUM_texture_mapping if we had named it).

http://codereview.chromium.org/6080012/diff/1/ppapi/c/dev/ppb_gles_chromium_e...
ppapi/c/dev/ppb_gles_chromium_extension_dev.h:14: void*
(*MapTexSubImage2DCHROMIUM)(
On 2011/01/06 17:58:24, brettw wrote:
> I don't quite get the naming convention. Why do we need CHROMIUM in all caps
at
> the end of each of these functions? It might also be nice to have some
> documentation, even if brief (and mentioning that you should unmap it).

Done. I added the doc. The naming comes from standard naming in OpenGL, where
the vendors have a suffix namespace consisting of the upper-case name, e.g. NV,
SGI, APPLE, ...
Note that I'm not making up new names, it's coming from existing code.

http://codereview.chromium.org/6080012/diff/1/webkit/plugins/ppapi/ppb_gles_c...
File webkit/plugins/ppapi/ppb_gles_chromium_extension_impl.cc (right):

http://codereview.chromium.org/6080012/diff/1/webkit/plugins/ppapi/ppb_gles_c...
webkit/plugins/ppapi/ppb_gles_chromium_extension_impl.cc:5: // This file is
auto-generated. DO NOT EDIT!
On 2011/01/06 16:50:30, apatrick wrote:
> Are the changes to the python script that generate this file in another
> changelist?

The comment was copy/paste from existing code and wrong. I removed it. The file
is not auto-generated.

http://codereview.chromium.org/6080012/diff/1/webkit/plugins/ppapi/ppb_gles_c...
webkit/plugins/ppapi/ppb_gles_chromium_extension_impl.cc:19: PP_Resource
context_id,
On 2011/01/06 17:58:24, brettw wrote:
> Should be indented 4 spaces.

Done.

[apatrick_chromium, 2011-01-06 22:41:53]

LGTM for my part.

[brettw, 2011-01-07 18:32:38]

LGTM