ppapi/c/dev/ppb_gles_chromium_extension_dev.h - Issue 6080012: Expose Map/UnmapTexSubImage2DCHROMIUM to pepper plugins

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/c/dev/ppb_gles_chromium_extension_dev.h

Issue 6080012: Expose Map/UnmapTexSubImage2DCHROMIUM to pepper plugins (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef PPAPI_C_DEV_PPB_GLES_CHROMIUM_EXTENSION_DEV_H_

	6 #define PPAPI_C_DEV_PPB_GLES_CHROMIUM_EXTENSION_DEV_H_

	7

	8 #include "ppapi/c/pp_resource.h"

	9 #include "ppapi/c/dev/ppb_opengles_dev.h"

	10

	11 #define PPB_GLES_CHROMIUM_EXTENSION_DEV_INTERFACE "PPB_GLESChromiumExtension(Dev );0.1"

	12

	13 struct PPB_GLESChromiumExtension_Dev {
	apatrick 2011/01/06 16:50:30 There will be other CHROMIUM extensions in the fut There will be other CHROMIUM extensions in the future and we'll want a separate PPAPI interface for each of them. Perhaps name this after the feature it provides, i.e. mapping and unmapping a texture? piman 2011/01/06 22:31:12 Done. I called it ChromiumTextureMapping (under th Show quoted text On 2011/01/06 16:50:30, apatrick wrote: > There will be other CHROMIUM extensions in the future and we'll want a separate > PPAPI interface for each of them. Perhaps name this after the feature it > provides, i.e. mapping and unmapping a texture? Done. I called it ChromiumTextureMapping (under the assumption that the extension would be called GL_CHROMIUM_texture_mapping if we had named it).
	14 void* (*MapTexSubImage2DCHROMIUM)(
	brettw 2011/01/06 17:58:24 I don't quite get the naming convention. Why do we I don't quite get the naming convention. Why do we need CHROMIUM in all caps at the end of each of these functions? It might also be nice to have some documentation, even if brief (and mentioning that you should unmap it). piman 2011/01/06 22:31:12 Done. I added the doc. The naming comes from stand Show quoted text On 2011/01/06 17:58:24, brettw wrote: > I don't quite get the naming convention. Why do we need CHROMIUM in all caps at > the end of each of these functions? It might also be nice to have some > documentation, even if brief (and mentioning that you should unmap it). Done. I added the doc. The naming comes from standard naming in OpenGL, where the vendors have a suffix namespace consisting of the upper-case name, e.g. NV, SGI, APPLE, ... Note that I'm not making up new names, it's coming from existing code.
	15 PP_Resource context,

	16 GLenum target,

	17 GLint level,

	18 GLint xoffset,

	19 GLint yoffset,

	20 GLsizei width,

	21 GLsizei height,

	22 GLenum format,

	23 GLenum type,

	24 GLenum access);

	25 void (UnmapTexSubImage2DCHROMIUM)(PP_Resource context, const void mem);

	26 };

	27

	28 #endif // PPAPI_C_DEV_PPB_GLES_CHROMIUM_EXTENSION_DEV_H_

OLD	NEW

« no previous file with comments | « no previous file | webkit/glue/webkit_glue.gypi » ('j') | webkit/plugins/ppapi/ppb_gles_chromium_extension_impl.cc » ('J')