Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: chrome/browser/metrics/metrics_log.cc

Issue 6077013: Add support for collecting non-Chrome crash stats in Chrome OS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_log.cc
===================================================================
--- chrome/browser/metrics/metrics_log.cc (revision 69359)
+++ chrome/browser/metrics/metrics_log.cc (working copy)
@@ -231,6 +231,32 @@
pref->SetInteger(prefs::kStabilityChildProcessCrashCount, 0);
}
+#if defined(OS_CHROMEOS)
+ count = pref->GetInteger(prefs::kStabilityOtherUserCrashCount);
petkov 2011/01/06 18:50:36 did you forget to add the file that declares/defin
kmixter1 2011/01/14 00:07:02 Done.
+ if (count) {
+ // TODO(kmixter): Write attribute once log server supports it.
+ // WriteIntAttribute("otherusercrashcount", count);
+ LOG(WARNING) << "Would write otherusercrashcount=" << count;
petkov 2011/01/06 18:50:36 you'll remove these logs eventually, i assume.
kmixter1 2011/01/14 00:07:02 Yes, until the log server can handle these additio
+ pref->SetInteger(prefs::kStabilityOtherUserCrashCount, 0);
+ }
+
+ count = pref->GetInteger(prefs::kStabilityKernelCrashCount);
+ if (count) {
+ // TODO(kmixter): Write attribute once log server supports it.
+ // WriteIntAttribute("kernelcrashcount", count);
+ LOG(WARNING) << "Would write kernelcrashcount=" << count;
+ pref->SetInteger(prefs::kStabilityKernelCrashCount, 0);
+ }
+
+ count = pref->GetInteger(prefs::kStabilitySystemUncleanShutdownCount);
+ if (count) {
+ // TODO(kmixter): Write attribute once log server supports it.
+ // WriteIntAttribute("systemuncleanshutdowns", count);
+ LOG(WARNING) << "Would write systemuncleanshutdowns=" << count;
+ pref->SetInteger(prefs::kStabilitySystemUncleanShutdownCount, 0);
+ }
+#endif // OS_CHROMEOS
+
int64 recent_duration = GetIncrementalUptime(pref);
if (recent_duration)
WriteInt64Attribute("uptimesec", recent_duration);

Powered by Google App Engine
This is Rietveld 408576698