Add support for collecting non-Chrome crash stats in Chrome OS

chrome/browser/metrics/metrics_log.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/metrics_log.h"
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 213 matching lines @@
     WriteIntAttribute("rendererhangcount", count);
     pref->SetInteger(prefs::kStabilityRendererHangCount, 0);
   }
 
   count = pref->GetInteger(prefs::kStabilityChildProcessCrashCount);
   if (count) {
     WriteIntAttribute("childprocesscrashcount", count);
     pref->SetInteger(prefs::kStabilityChildProcessCrashCount, 0);
   }
 
+#if defined(OS_CHROMEOS)
+  count = pref->GetInteger(prefs::kStabilityOtherUserCrashCount);

[petkov, 2011/01/06 18:50:36]

did you forget to add the file that declares/defines the prefs strings?

[kmixter1, 2011/01/14 00:07:02]

Done.

+  if (count) {
+    // TODO(kmixter): Write attribute once log server supports it.
+    // WriteIntAttribute("otherusercrashcount", count);
+    LOG(WARNING) << "Would write otherusercrashcount=" << count;

[petkov, 2011/01/06 18:50:36]

you'll remove these logs eventually, i assume.

[kmixter1, 2011/01/14 00:07:02]

Yes, until the log server can handle these additional attributes (it throws away
tags with unexpected attributes) we just log them out locally to prove we're
capturing the right values.  Made intention clear in TODO.

+    pref->SetInteger(prefs::kStabilityOtherUserCrashCount, 0);
+  }
+
+  count = pref->GetInteger(prefs::kStabilityKernelCrashCount);
+  if (count) {
+    // TODO(kmixter): Write attribute once log server supports it.
+    // WriteIntAttribute("kernelcrashcount", count);
+    LOG(WARNING) << "Would write kernelcrashcount=" << count;
+    pref->SetInteger(prefs::kStabilityKernelCrashCount, 0);
+  }
+
+  count = pref->GetInteger(prefs::kStabilitySystemUncleanShutdownCount);
+  if (count) {
+    // TODO(kmixter): Write attribute once log server supports it.
+    // WriteIntAttribute("systemuncleanshutdowns", count);
+    LOG(WARNING) << "Would write systemuncleanshutdowns=" << count;
+    pref->SetInteger(prefs::kStabilitySystemUncleanShutdownCount, 0);
+  }
+#endif  // OS_CHROMEOS
+
   int64 recent_duration = GetIncrementalUptime(pref);
   if (recent_duration)
     WriteInt64Attribute("uptimesec", recent_duration);
 }
 
 void MetricsLog::WritePluginList(
          const std::vector<WebPluginInfo>& plugin_list) {
   DCHECK(!locked_);
 
   OPEN_ELEMENT_FOR_SCOPE("plugins");
@@ skipping 203 matching lines @@
       const std::string result_type(AutocompleteMatch::TypeToString(i->type));
       if (!result_type.empty())
         WriteAttribute("resulttype", result_type);
       WriteIntAttribute("relevance", i->relevance);
       WriteIntAttribute("isstarred", i->starred ? 1 : 0);
     }
   }
 
   ++num_events_;
 }