src/ia32/lithium-ia32.cc - Issue 6072009: Don't emit a write barrier when storing a known old space value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-ia32.cc

Issue 6072009: Don't emit a write barrier when storing a known old space value. (Closed)

Patch Set: Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/lithium-ia32.cc

diff --git a/src/ia32/lithium-ia32.cc b/src/ia32/lithium-ia32.cc

index dede47013587984341f456394166eb787bf576cc..44f0417744cb4b732ceecbefe5cf7bf3372c8d0d 100644

--- a/src/ia32/lithium-ia32.cc

+++ b/src/ia32/lithium-ia32.cc

@@ -1939,7 +1939,7 @@ LInstruction* LChunkBuilder::DoStoreKeyedGeneric(HStoreKeyedGeneric* instr) {

LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) {

- bool needs_write_barrier = !instr->value()->type().IsSmi();

+ bool needs_write_barrier = instr->NeedsWriteBarrier();

LOperand* obj = needs_write_barrier

? UseTempRegister(instr->object())

« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »