Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1515)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 6072009: Don't emit a write barrier when storing a known old space value. (Closed)
Patch Set: Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1921 matching lines...) Expand 10 before | Expand all | Expand 10 after
1932 1932
1933 ASSERT(instr->object()->representation().IsTagged()); 1933 ASSERT(instr->object()->representation().IsTagged());
1934 ASSERT(instr->key()->representation().IsTagged()); 1934 ASSERT(instr->key()->representation().IsTagged());
1935 ASSERT(instr->value()->representation().IsTagged()); 1935 ASSERT(instr->value()->representation().IsTagged());
1936 1936
1937 return MarkAsCall(new LStoreKeyedGeneric(obj, key, val), instr); 1937 return MarkAsCall(new LStoreKeyedGeneric(obj, key, val), instr);
1938 } 1938 }
1939 1939
1940 1940
1941 LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) { 1941 LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) {
1942 bool needs_write_barrier = !instr->value()->type().IsSmi(); 1942 bool needs_write_barrier = instr->NeedsWriteBarrier();
1943 1943
1944 LOperand* obj = needs_write_barrier 1944 LOperand* obj = needs_write_barrier
1945 ? UseTempRegister(instr->object()) 1945 ? UseTempRegister(instr->object())
1946 : UseRegisterAtStart(instr->object()); 1946 : UseRegisterAtStart(instr->object());
1947 1947
1948 LOperand* val = needs_write_barrier 1948 LOperand* val = needs_write_barrier
1949 ? UseTempRegister(instr->value()) 1949 ? UseTempRegister(instr->value())
1950 : UseRegister(instr->value()); 1950 : UseRegister(instr->value());
1951 1951
1952 // We only need a scratch register if we have a write barrier or we 1952 // We only need a scratch register if we have a write barrier or we
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
2127 void LPointerMap::PrintTo(StringStream* stream) const { 2127 void LPointerMap::PrintTo(StringStream* stream) const {
2128 stream->Add("{"); 2128 stream->Add("{");
2129 for (int i = 0; i < pointer_operands_.length(); ++i) { 2129 for (int i = 0; i < pointer_operands_.length(); ++i) {
2130 if (i != 0) stream->Add(";"); 2130 if (i != 0) stream->Add(";");
2131 pointer_operands_[i]->PrintTo(stream); 2131 pointer_operands_[i]->PrintTo(stream);
2132 } 2132 }
2133 stream->Add("} @%d", position()); 2133 stream->Add("} @%d", position());
2134 } 2134 }
2135 2135
2136 } } // namespace v8::internal 2136 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698