Block outdated plugins by default.

Block outdated plugins by default.

To allow outdated plugins, pass the new --allow-outdated-plugins command line flag.

Also, remove the unused "block nonsandboxed plug-ins" command line flag.

BUG=47731
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69884

[Bernhard Bauer, 2010-12-21 20:48:16]

please review.

[cevans, 2010-12-21 20:57:01]

Depressingly, might there be companies who want to turn this off because of
specific e.g. Java version requirements? Should we keep the flag, but with
the inverse meaning?

On Tue, Dec 21, 2010 at 12:48 PM, <bauerb@chromium.org> wrote:

> Reviewers: Peter Kasting,
>
> Message:
> please review.
>
> Description:
> Enable blocking outdated plugins by default.
>
> Also, remove the unused "block nonsandboxed plug-ins" command line flag.
>
> BUG=47731
> TEST=none
>
> Please review this at http://codereview.chromium.org/6065004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/app/generated_resources.grd
>  M chrome/browser/about_flags.cc
>  M chrome/browser/renderer_host/browser_render_process_host.cc
>  M chrome/common/chrome_switches.h
>  M chrome/common/chrome_switches.cc
>  M chrome/renderer/render_view.cc
>
>
> Index: chrome/app/generated_resources.grd
> diff --git a/chrome/app/generated_resources.grd
> b/chrome/app/generated_resources.grd
> index
>
32c45c2b69a4dc7d9a97604c41531948f580aa1d..57190ab3950e4ea564ef99feae340a9fc3092cf7
> 100644
> --- a/chrome/app/generated_resources.grd
> +++ b/chrome/app/generated_resources.grd
> @@ -4276,7 +4276,7 @@ Keep your key file in a safe place. You will need it
> to create new versions of y
>
>       <!-- Click to play -->
>       <message name="IDS_PLUGIN_LOAD" desc="The link for loading a blocked
> plug-in, displayed in the click to play UI.">
> -        Click to run the <ph name="PLUGIN_NAME">$1<ex>Flash</ex></ph>
> plug-in
> +        Click to run the <ph name="PLUGIN_NAME">$1<ex>Flash</ex></ph>
> plug-in.
>       </message>
>       <message name="IDS_PLUGIN_UPDATE" desc="The link for updating an
> outdated plug-in.">
>         Update plug-in...
> Index: chrome/browser/about_flags.cc
> diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
> index
>
55deba58801ff4edd1cba0c2dbce36e245dd0e20..21ae4f568ce26eb43bd2118855dca9e87ce0791d
> 100644
> --- a/chrome/browser/about_flags.cc
> +++ b/chrome/browser/about_flags.cc
> @@ -145,13 +145,6 @@ const Experiment kExperiments[] = {
>     SINGLE_VALUE_TYPE(switches::kEnableRemoting)
>   },
>   {
> -    "disable-outdated-plugins",  // FLAGS:RECORD_UMA
> -    IDS_FLAGS_DISABLE_OUTDATED_PLUGINS_NAME,
> -    IDS_FLAGS_DISABLE_OUTDATED_PLUGINS_DESCRIPTION,
> -    kOsAll,
> -    SINGLE_VALUE_TYPE(switches::kBlockOutdatedPlugins)
> -  },
> -  {
>     "xss-auditor",  // FLAGS:RECORD_UMA
>     IDS_FLAGS_XSS_AUDITOR_NAME,
>     IDS_FLAGS_XSS_AUDITOR_DESCRIPTION,
> Index: chrome/browser/renderer_host/browser_render_process_host.cc
> diff --git a/chrome/browser/renderer_host/browser_render_process_host.cc
> b/chrome/browser/renderer_host/browser_render_process_host.cc
> index
>
677bb942b2ba639f7053ece07659b984fff455ce..e51781d407901fcad3be84ab870bf2c0e562b463
> 100644
> --- a/chrome/browser/renderer_host/browser_render_process_host.cc
> +++ b/chrome/browser/renderer_host/browser_render_process_host.cc
> @@ -688,8 +688,6 @@ void
> BrowserRenderProcessHost::PropagateBrowserCommandLineToRenderer(
>  #endif
>     switches::kRemoteShellPort,
>     switches::kEnablePepperTesting,
> -    switches::kBlockNonSandboxedPlugins,
> -    switches::kBlockOutdatedPlugins,
>     switches::kEnableRemoting,
>     switches::kEnableClickToPlay,
>     switches::kEnableResourceContentSettings,
> Index: chrome/common/chrome_switches.cc
> diff --git a/chrome/common/chrome_switches.cc
> b/chrome/common/chrome_switches.cc
> index
>
84236bb125bce40878ce38893240855017b7f81a..8fda468309db6778a05812f42feb4fc87b8c9c40
> 100644
> --- a/chrome/common/chrome_switches.cc
> +++ b/chrome/common/chrome_switches.cc
> @@ -84,12 +84,6 @@ const char kAuthServerWhitelist[] =
> "auth-server-whitelist";
>  // automation-related messages on IPC channel with the given ID.
>  const char kAutomationClientChannelID[]     = "automation-channel";
>
> -// Block non-sandboxed plugins.
> -const char kBlockNonSandboxedPlugins[]      =
> "block-nonsandboxed-plugins";
> -
> -// Prevent outdated plugins from running.
> -const char kBlockOutdatedPlugins[]          = "block-outdated-plugins";
> -
>  // Causes the browser process to throw an assertion on startup.
>  const char kBrowserAssertTest[]             = "assert-test";
>
> Index: chrome/common/chrome_switches.h
> diff --git a/chrome/common/chrome_switches.h
> b/chrome/common/chrome_switches.h
> index
>
2a3f11d35f7ba611dcc4da64c7ebfd6b93565b64..51af328f780b2100fb4a3576e47501d542569bba
> 100644
> --- a/chrome/common/chrome_switches.h
> +++ b/chrome/common/chrome_switches.h
> @@ -37,8 +37,6 @@ extern const char kAuthNegotiateDelegateWhitelist[];
>  extern const char kAuthSchemes[];
>  extern const char kAuthServerWhitelist[];
>  extern const char kAutomationClientChannelID[];
> -extern const char kBlockNonSandboxedPlugins[];
> -extern const char kBlockOutdatedPlugins[];
>  extern const char kBrowserAssertTest[];
>  extern const char kBrowserCrashTest[];
>  extern const char kBrowserSubprocessPath[];
> Index: chrome/renderer/render_view.cc
> diff --git a/chrome/renderer/render_view.cc
> b/chrome/renderer/render_view.cc
> index
>
2c50d8ee0e7a6b42a19cdc19e88c02ea37959ffc..357c821a7afef5f789ca01a8e8640b73b970583b
> 100644
> --- a/chrome/renderer/render_view.cc
> +++ b/chrome/renderer/render_view.cc
> @@ -2773,8 +2773,7 @@ WebPlugin* RenderView::createPlugin(WebFrame* frame,
>       NPAPI::PluginList::Singleton()->GetPluginGroup(info);
>   DCHECK(group != NULL);
>
> -  if (cmd->HasSwitch(switches::kBlockOutdatedPlugins) &&
> -      group->IsVulnerable()) {
> +  if (group->IsVulnerable()) {
>     Send(new ViewHostMsg_BlockedOutdatedPlugin(routing_id_,
>                                                group->GetGroupName(),
>
>  GURL(group->GetUpdateURL())));
>
>
>

[Bernhard Bauer, 2010-12-21 21:08:54]

Hmm, true. Added a flag for that.

On Tue, Dec 21, 2010 at 12:56, Chris Evans <cevans@google.com> wrote:
> Depressingly, might there be companies who want to turn this off because of
> specific e.g. Java version requirements? Should we keep the flag, but with
> the inverse meaning?
>
> On Tue, Dec 21, 2010 at 12:48 PM, <bauerb@chromium.org> wrote:
>>
>> Reviewers: Peter Kasting,
>>
>> Message:
>> please review.
>>
>> Description:
>> Enable blocking outdated plugins by default.
>>
>> Also, remove the unused "block nonsandboxed plug-ins" command line flag.
>>
>> BUG=47731
>> TEST=none
>>
>> Please review this at http://codereview.chromium.org/6065004/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files:
>>  M chrome/app/generated_resources.grd
>>  M chrome/browser/about_flags.cc
>>  M chrome/browser/renderer_host/browser_render_process_host.cc
>>  M chrome/common/chrome_switches.h
>>  M chrome/common/chrome_switches.cc
>>  M chrome/renderer/render_view.cc
>>
>>
>> Index: chrome/app/generated_resources.grd
>> diff --git a/chrome/app/generated_resources.grd
>> b/chrome/app/generated_resources.grd
>> index
>>
32c45c2b69a4dc7d9a97604c41531948f580aa1d..57190ab3950e4ea564ef99feae340a9fc3092cf7
>> 100644
>> --- a/chrome/app/generated_resources.grd
>> +++ b/chrome/app/generated_resources.grd
>> @@ -4276,7 +4276,7 @@ Keep your key file in a safe place. You will need it
>> to create new versions of y
>>
>>       <!-- Click to play -->
>>       <message name="IDS_PLUGIN_LOAD" desc="The link for loading a blocked
>> plug-in, displayed in the click to play UI.">
>> -        Click to run the <ph name="PLUGIN_NAME">$1<ex>Flash</ex></ph>
>> plug-in
>> +        Click to run the <ph name="PLUGIN_NAME">$1<ex>Flash</ex></ph>
>> plug-in.
>>       </message>
>>       <message name="IDS_PLUGIN_UPDATE" desc="The link for updating an
>> outdated plug-in.">
>>         Update plug-in...
>> Index: chrome/browser/about_flags.cc
>> diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
>> index
>>
55deba58801ff4edd1cba0c2dbce36e245dd0e20..21ae4f568ce26eb43bd2118855dca9e87ce0791d
>> 100644
>> --- a/chrome/browser/about_flags.cc
>> +++ b/chrome/browser/about_flags.cc
>> @@ -145,13 +145,6 @@ const Experiment kExperiments[] = {
>>     SINGLE_VALUE_TYPE(switches::kEnableRemoting)
>>   },
>>   {
>> -    "disable-outdated-plugins",  // FLAGS:RECORD_UMA
>> -    IDS_FLAGS_DISABLE_OUTDATED_PLUGINS_NAME,
>> -    IDS_FLAGS_DISABLE_OUTDATED_PLUGINS_DESCRIPTION,
>> -    kOsAll,
>> -    SINGLE_VALUE_TYPE(switches::kBlockOutdatedPlugins)
>> -  },
>> -  {
>>     "xss-auditor",  // FLAGS:RECORD_UMA
>>     IDS_FLAGS_XSS_AUDITOR_NAME,
>>     IDS_FLAGS_XSS_AUDITOR_DESCRIPTION,
>> Index: chrome/browser/renderer_host/browser_render_process_host.cc
>> diff --git a/chrome/browser/renderer_host/browser_render_process_host.cc
>> b/chrome/browser/renderer_host/browser_render_process_host.cc
>> index
>>
677bb942b2ba639f7053ece07659b984fff455ce..e51781d407901fcad3be84ab870bf2c0e562b463
>> 100644
>> --- a/chrome/browser/renderer_host/browser_render_process_host.cc
>> +++ b/chrome/browser/renderer_host/browser_render_process_host.cc
>> @@ -688,8 +688,6 @@ void
>> BrowserRenderProcessHost::PropagateBrowserCommandLineToRenderer(
>>  #endif
>>     switches::kRemoteShellPort,
>>     switches::kEnablePepperTesting,
>> -    switches::kBlockNonSandboxedPlugins,
>> -    switches::kBlockOutdatedPlugins,
>>     switches::kEnableRemoting,
>>     switches::kEnableClickToPlay,
>>     switches::kEnableResourceContentSettings,
>> Index: chrome/common/chrome_switches.cc
>> diff --git a/chrome/common/chrome_switches.cc
>> b/chrome/common/chrome_switches.cc
>> index
>>
84236bb125bce40878ce38893240855017b7f81a..8fda468309db6778a05812f42feb4fc87b8c9c40
>> 100644
>> --- a/chrome/common/chrome_switches.cc
>> +++ b/chrome/common/chrome_switches.cc
>> @@ -84,12 +84,6 @@ const char kAuthServerWhitelist[] =
>> "auth-server-whitelist";
>>  // automation-related messages on IPC channel with the given ID.
>>  const char kAutomationClientChannelID[]     = "automation-channel";
>>
>> -// Block non-sandboxed plugins.
>> -const char kBlockNonSandboxedPlugins[]      =
>> "block-nonsandboxed-plugins";
>> -
>> -// Prevent outdated plugins from running.
>> -const char kBlockOutdatedPlugins[]          = "block-outdated-plugins";
>> -
>>  // Causes the browser process to throw an assertion on startup.
>>  const char kBrowserAssertTest[]             = "assert-test";
>>
>> Index: chrome/common/chrome_switches.h
>> diff --git a/chrome/common/chrome_switches.h
>> b/chrome/common/chrome_switches.h
>> index
>>
2a3f11d35f7ba611dcc4da64c7ebfd6b93565b64..51af328f780b2100fb4a3576e47501d542569bba
>> 100644
>> --- a/chrome/common/chrome_switches.h
>> +++ b/chrome/common/chrome_switches.h
>> @@ -37,8 +37,6 @@ extern const char kAuthNegotiateDelegateWhitelist[];
>>  extern const char kAuthSchemes[];
>>  extern const char kAuthServerWhitelist[];
>>  extern const char kAutomationClientChannelID[];
>> -extern const char kBlockNonSandboxedPlugins[];
>> -extern const char kBlockOutdatedPlugins[];
>>  extern const char kBrowserAssertTest[];
>>  extern const char kBrowserCrashTest[];
>>  extern const char kBrowserSubprocessPath[];
>> Index: chrome/renderer/render_view.cc
>> diff --git a/chrome/renderer/render_view.cc
>> b/chrome/renderer/render_view.cc
>> index
>>
2c50d8ee0e7a6b42a19cdc19e88c02ea37959ffc..357c821a7afef5f789ca01a8e8640b73b970583b
>> 100644
>> --- a/chrome/renderer/render_view.cc
>> +++ b/chrome/renderer/render_view.cc
>> @@ -2773,8 +2773,7 @@ WebPlugin* RenderView::createPlugin(WebFrame* frame,
>>       NPAPI::PluginList::Singleton()->GetPluginGroup(info);
>>   DCHECK(group != NULL);
>>
>> -  if (cmd->HasSwitch(switches::kBlockOutdatedPlugins) &&
>> -      group->IsVulnerable()) {
>> +  if (group->IsVulnerable()) {
>>     Send(new ViewHostMsg_BlockedOutdatedPlugin(routing_id_,
>>                                                group->GetGroupName(),
>>
>>  GURL(group->GetUpdateURL())));
>>
>>
>
>

[Peter Kasting, 2010-12-21 21:47:12]

LGTM