Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7342)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/render_view.cc

Issue 6065004: Block outdated plugins by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add flag to allow outdated plugins Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_view.cc
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index 2c50d8ee0e7a6b42a19cdc19e88c02ea37959ffc..dbb67343a8ba784e1b3e503d90cc24dd59b21933 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -2773,8 +2773,8 @@ WebPlugin* RenderView::createPlugin(WebFrame* frame,
NPAPI::PluginList::Singleton()->GetPluginGroup(info);
DCHECK(group != NULL);
- if (cmd->HasSwitch(switches::kBlockOutdatedPlugins) &&
- group->IsVulnerable()) {
+ if (group->IsVulnerable() &&
+ !cmd->HasSwitch(switches::kAllowOutdatedPlugins)) {
Send(new ViewHostMsg_BlockedOutdatedPlugin(routing_id_,
group->GetGroupName(),
GURL(group->GetUpdateURL())));
@@ -2784,6 +2784,7 @@ WebPlugin* RenderView::createPlugin(WebFrame* frame,
IDR_BLOCKED_PLUGIN_HTML,
IDS_PLUGIN_OUTDATED);
}
+
if (!info.enabled)
return NULL;
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698