Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 6053008: Improve validation of external extension ids. (Closed)

Created:
9 years, 11 months ago by Sam Kerner (Chrome)
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr., Aaron Boodman
Visibility:
Public.

Description

Improve validation of external extesnion ids. BUG=68478 TEST=ExtensionServiceTest.ExternalPrefProvider, add an extension key to the windows registry with a typo in the id. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71448

Patch Set 1 : Fix long line. #

Patch Set 2 : Rebase. #

Patch Set 3 : Retest on win. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -22 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_updater.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_extension_provider_impl.cc View 1 2 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/extensions/external_extension_provider_interface.h View 1 1 chunk +13 lines, -12 lines 0 comments Download
M chrome/browser/extensions/external_registry_extension_loader_win.cc View 1 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sam Kerner (Chrome)
9 years, 11 months ago (2011-01-04 18:02:43 UTC) #1
Aaron Boodman
9 years, 11 months ago (2011-01-06 19:11:57 UTC) #2
lgtm, seems like may conflict with http://codereview.chromium.org/5742008/
though.

Powered by Google App Engine
This is Rietveld 408576698