chrome/browser/extensions/extension_updater.cc - Issue 6053008: Improve validation of external extension ids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_updater.cc

Issue 6053008: Improve validation of external extension ids. (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: Retest on win. Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_updater.cc

diff --git a/chrome/browser/extensions/extension_updater.cc b/chrome/browser/extensions/extension_updater.cc

index b7d4f1f0f8f754853ea781666812a189accd6d08..01b0e07a87cbcf5be6cdf733f1c156296b7c421c 100644

--- a/chrome/browser/extensions/extension_updater.cc

+++ b/chrome/browser/extensions/extension_updater.cc

@@ -766,7 +766,7 @@ void ExtensionUpdater::CheckNow() {

// Start a fetch of the blacklist if needed.

if (blacklist_checks_enabled_ && service_->HasInstalledExtensions()) {

- // Note: it is very important that we use the https version of the update

+ // Note: it is very important that we use the https version of the update

// url here to avoid DNS hijacking of the blacklist, which is not validated

// by a public key signature like .crx files are.

ManifestFetchData* blacklist_fetch =