Added WARN_UNUSED_RESULT to ScopedTempDir methods.

chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

Index: chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
diff --git a/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc b/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
index 19cd3796a895a0da9cabe9bf54ce4c7ee17cb89c..6246a6fd45ab57b25af4e9875c4baa971165707c 100644
--- a/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
+++ b/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
@@ -100,16 +100,18 @@ class SandboxedExtensionUnpackerTest : public testing::Test {
     // Hack since SandboxedExtensionUnpacker gets its background thread id from
     // the Start call, but we don't call it here.
     sandboxed_unpacker_->thread_identifier_ = BrowserThread::FILE;
-    PrepareUnpackerEnv();
+    EXPECT_TRUE(PrepareUnpackerEnv());
   }
 
-  void PrepareUnpackerEnv() {
+  bool PrepareUnpackerEnv() {

[Paweł Hajdan Jr., 2011/01/11 13:01:10]

nit: It may be useful to propagate WARN_UNUSED_RESULT here.

[cbentzel, 2011/01/11 19:56:38]

I'll hold off on this - I don't have as much context about this method.

     sandboxed_unpacker_->extension_root_ =
       install_dir_.AppendASCII(extension_filenames::kTempExtensionName);
 
-    sandboxed_unpacker_->temp_dir_.Set(install_dir_);
+    if (!sandboxed_unpacker_->temp_dir_.Set(install_dir_))
+      return false;
     sandboxed_unpacker_->public_key_ =
       "ocnapchkplbmjmpfehjocmjnipfmogkh";
+    return true;
   }
 
   void OnUnpackSucceeded() {