Added WARN_UNUSED_RESULT to ScopedTempDir methods.

chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/ref_counted.h"
 #include "base/scoped_temp_dir.h"
 #include "base/string_util.h"
 #include "chrome/browser/extensions/sandboxed_extension_unpacker.h"
@@ skipping 82 matching lines @@
     // Build a temp area where the extension will be unpacked.
     ASSERT_TRUE(PathService::Get(base::DIR_TEMP, &temp_dir_));
     temp_dir_ = temp_dir_.AppendASCII("sandboxed_extension_unpacker_test_Temp");
     file_util::CreateDirectory(temp_dir_);
 
     sandboxed_unpacker_ =
       new SandboxedExtensionUnpacker(crx_path, temp_dir_, NULL, client_);
     // Hack since SandboxedExtensionUnpacker gets its background thread id from
     // the Start call, but we don't call it here.
     sandboxed_unpacker_->thread_identifier_ = BrowserThread::FILE;
-    PrepareUnpackerEnv();
+    EXPECT_TRUE(PrepareUnpackerEnv());
   }
 
-  void PrepareUnpackerEnv() {
+  bool PrepareUnpackerEnv() {

[Paweł Hajdan Jr., 2011/01/11 13:01:10]

nit: It may be useful to propagate WARN_UNUSED_RESULT here.

[cbentzel, 2011/01/11 19:56:38]

I'll hold off on this - I don't have as much context about this method.

     sandboxed_unpacker_->extension_root_ =
       install_dir_.AppendASCII(extension_filenames::kTempExtensionName);
 
-    sandboxed_unpacker_->temp_dir_.Set(install_dir_);
+    if (!sandboxed_unpacker_->temp_dir_.Set(install_dir_))
+      return false;
     sandboxed_unpacker_->public_key_ =
       "ocnapchkplbmjmpfehjocmjnipfmogkh";
+    return true;
   }
 
   void OnUnpackSucceeded() {
     sandboxed_unpacker_->OnUnpackExtensionSucceeded(
         *unpacker_->parsed_manifest());
   }
 
   FilePath GetInstallPath() {
     return install_dir_.AppendASCII(extension_filenames::kTempExtensionName);
   }
@@ skipping 77 matching lines @@
   OnUnpackSucceeded();
 
   // Check that there is newer _locales/en_US/messages.json file.
   base::PlatformFileInfo new_info;
   EXPECT_TRUE(file_util::GetFileInfo(messages_file, &new_info));
 
   EXPECT_TRUE(new_info.last_modified > old_info.last_modified);
 
   ASSERT_TRUE(TempFilesRemoved());
 }