Issue 6038: Enable error checking on Posix locks in debug, and make release lock creation...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6038: Enable error checking on Posix locks in debug, and make release lock creation... (Closed)

Created:
12 years, 2 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, mendola

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable error checking on Posix locks in debug, and make release lock creation do a little bit less work. Based on suggestions by Gaetano Mendola.

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	base/lock_impl_posix.cc	View		1 chunk	+7 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM? Did you check in the "explicit" thing separately?

12 years, 2 months ago (2008-10-01 14:03:52 UTC) #2

mendola

12 years, 2 months ago (2008-10-01 14:25:21 UTC) #3

Added comment

http://codereview.chromium.org/6038/diff/1/2
File base/lock_impl_posix.cc (right):

http://codereview.chromium.org/6038/diff/1/2#newcode26
Line 26: #endif
this is fine if we want an undefined behavior in case of a relock instead of
deadlock, in case we prefer the deadlock then the mutex shall be initialized
with PTHREAD_MUTEX_NORMAL instead of PTHREAD_MUTEX_DEFAULT as it is now.

Expand Messages | Collapse Messages