Enable error checking on Posix locks in debug, and make release lock creation...

base/lock_impl_posix.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/lock_impl.h"
 
 #include <errno.h>
 
 #include "base/logging.h"
 
 LockImpl::LockImpl() {
+#ifndef NDEBUG
+  // In debug, setup attributes for lock error checking.
   pthread_mutexattr_t mta;
   int rv = pthread_mutexattr_init(&mta);
   DCHECK(rv == 0);
-  //rv = pthread_mutexattr_settype(&mta, PTHREAD_MUTEX_RECURSIVE);
+  rv = pthread_mutexattr_settype(&mta, PTHREAD_MUTEX_ERRORCHECK);
   DCHECK(rv == 0);
   rv = pthread_mutex_init(&os_lock_, &mta);
   DCHECK(rv == 0);
   rv = pthread_mutexattr_destroy(&mta);
   DCHECK(rv == 0);
+#else
+  // In release, go with the default lock attributes.
+  pthread_mutex_init(&os_lock_, NULL);
+#endif

[mendola, 2008/10/01 14:25:21]

this is fine if we want an undefined behavior in case of a relock instead of
deadlock, in case we prefer the deadlock then the mutex shall be initialized
with PTHREAD_MUTEX_NORMAL instead of PTHREAD_MUTEX_DEFAULT as it is now.

 }
 
 LockImpl::~LockImpl() {
   int rv = pthread_mutex_destroy(&os_lock_);
   DCHECK(rv == 0);
 }
 
 bool LockImpl::Try() {
   int rv = pthread_mutex_trylock(&os_lock_);
   DCHECK(rv == 0 || rv == EBUSY);
   return rv == 0;
 }
 
 void LockImpl::Lock() {
   int rv = pthread_mutex_lock(&os_lock_);
   DCHECK(rv == 0);
 }
 
 void LockImpl::Unlock() {
   int rv = pthread_mutex_unlock(&os_lock_);
   DCHECK(rv == 0);
 }