Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3896)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Issue 6036004: Refactor AutocompleteEditViewGtk so that AutocompleteEditView impl can be swapped. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h b/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
index dc09d9143779d37b8728d7b5f9fc01744ecdea97..7d448364f73a183084b1cad3a11049dc13d10e6b 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
+++ b/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
@@ -26,6 +26,7 @@
#include "gfx/rect.h"
#include "webkit/glue/window_open_disposition.h"
+class AccessibleWidgetHelper;
class AutocompleteEditController;
class AutocompleteEditModel;
class AutocompletePopupView;
@@ -71,19 +72,15 @@ class AutocompleteEditViewGtk : public AutocompleteEditView,
CommandUpdater* command_updater,
bool popup_window_mode,
#if defined(TOOLKIT_VIEWS)
- const views::View* location_bar);
+ const views::View* location_bar
#else
- GtkWidget* location_bar);
+ GtkWidget* location_bar
#endif
- ~AutocompleteEditViewGtk();
+ );
+ virtual ~AutocompleteEditViewGtk();
// Initialize, create the underlying widgets, etc.
void Init();
-
- // Returns the width in pixels needed to display the current text. The
- // returned value includes margins.
- int TextWidth();
-
// Returns the width in pixels needed to display the text from one character
// before the caret to the end of the string. See comments in
// LocationBarView::Layout as to why this uses -1.
@@ -143,6 +140,27 @@ class AutocompleteEditViewGtk : public AutocompleteEditView,
virtual bool OnAfterPossibleChange();
virtual gfx::NativeView GetNativeView() const;
virtual CommandUpdater* GetCommandUpdater();
+#if defined(TOOLKIT_VIEWS)
+ virtual views::View* AddToView(views::View* parent);
+ virtual bool CommitInstantSuggestion(const std::wstring& typed_text,
+ const std::wstring& suggested_text);
+ virtual void SetInstantSuggestion(const string16& suggestion);
+
+ // Enables accessibility on AutocompleteEditView.
+ void EnableAccessibility();
+
+ // A factory method to create an AutocompleteEditView instance initialized for
+ // linux_views. This currently returns an instance of
+ // AutocompleteEditViewGtk only, but AutocompleteEditViewViews will
+ // be added as an option when TextfieldViews is enabled.
+ static AutocompleteEditView* Create(AutocompleteEditController* controller,
+ ToolbarModel* toolbar_model,
+ Profile* profile,
+ CommandUpdater* command_updater,
+ bool popup_window_mode,
+ const views::View* location_bar);
+#endif
+ virtual int TextWidth() const;
// Overridden from NotificationObserver:
virtual void Observe(NotificationType type,
@@ -514,6 +532,10 @@ class AutocompleteEditViewGtk : public AutocompleteEditView,
GtkSignalRegistrar signals_;
+#if defined(TOOLKIT_VIEWS)
+ scoped_ptr<AccessibleWidgetHelper> accessible_widget_helper_;
+#endif
+
DISALLOW_COPY_AND_ASSIGN(AutocompleteEditViewGtk);
};

Powered by Google App Engine
This is Rietveld 408576698