Refactor AutocompleteEditViewGtk so that AutocompleteEditView impl can be swapped.

chrome/browser/autocomplete/autocomplete_edit_view.h

Index: chrome/browser/autocomplete/autocomplete_edit_view.h
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view.h b/chrome/browser/autocomplete/autocomplete_edit_view.h
index 439b2edce7b6cb36baa3a94efebf4392095694e7..12c42a239ac2dc8a323da48f17c180e4147c95ee 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_view.h
+++ b/chrome/browser/autocomplete/autocomplete_edit_view.h
@@ -24,6 +24,12 @@ class CommandUpdater;
 class GURL;
 class TabContents;
 
+#if defined(TOOLKIT_VIEWS)
+namespace views {
+class View;
+}  // namespace views
+#endif
+
 class AutocompleteEditView {
  public:
   // Used by the automation system for getting at the model from the view.
@@ -152,7 +158,23 @@ class AutocompleteEditView {
   // Returns the command updater for this view.
   virtual CommandUpdater* GetCommandUpdater() = 0;
 
- protected:
+#if defined(TOOLKIT_VIEWS)
+  // Adds the autocomplete edit view to view hierarchy and
+  // returns the views::View of the edit view.
+  virtual views::View* AddToView(views::View* parent) = 0;
+
+  // Commits the suggested text.
+  virtual bool CommitInstantSuggestion(const std::wstring& typed_text,
+                                       const std::wstring& suggested_text) = 0;

[James Su, 2011/01/06 23:01:35]

The implementation of this method on all platforms should be same. Actually, the
current implementation is just a call to model()->FinalizeInstantQuery(). So
maybe it's better to remove this method from all implementations and just call
FinalizeInstantQuery() in location bar view. Then the only thing we need for
this View interface is a GetInstantSuggestText() method. Maybe we can add a same
method to AutocompleteEditController interface and provide different
implementations in location bar classes.
What's your opinion about it? 

[oshima, 2011/01/06 23:32:45]

I really like the idea to have the same implementation, but I need to look into
more before
making big changes to it. I'm planning to move suggested_text_view to
AutocompleteEditView impl,
which matches other platforms impl, and it will have some impact on this change
too, so
I'd like to defer it to future refactoring.

[James Su, 2011/01/06 23:49:08]

Then I'd prefer not to refactor this part for now. It's not worth to add this
method temporarily if we are going to remove it later.

And I'm wondering how would you move suggest_text_view into the
AutocompleteEditView's impl? It seems not doable for AutocompleteEditViewWin.

[oshima, 2011/01/07 01:49:39]

I can't eliminate Gtk's type without common method. It's pertty common to
add/update/remove methods during refactoring (and you'll never know the final
form until you finish it), so I think it's okay to add this now even if we may
modify it later.
It's possible. Whether or not it will be LGTM by scott is different story though
:) I think it's good move because it will make all implementation consistent
(mac and gtk has this info inside AutocompleteEditView, and Views impl will be
the same).

+
+  // Shows the instant suggestion text.
+  virtual void SetInstantSuggestion(const string16& input) = 0;

[James Su, 2011/01/06 23:49:08]

It's probably better to generalize this method for all platforms as well. Mac
port has SetSuggestText() for the same purpose.

[oshima, 2011/01/07 01:49:39]

Good idea. I'll do it, but in separate CL. I'd like to avoid touching mac file
in this CL.

+
+  // Returns the width in pixels needed to display the current text. The
+  // returned value includes margins.
+  virtual int TextWidth() const = 0;

[James Su, 2011/01/06 23:01:35]

How about move it out of the #if block? It's necessary for both Views and Gtk
ports.

[oshima, 2011/01/06 23:32:45]

I didn't do so because mac doesn't have it. I can add NOTREACHED impl to mac if
you want. Please let me know.

[James Su, 2011/01/06 23:49:08]

I'd prefer to move it out of the #if block, as Gtk port also has it.

[oshima, 2011/01/07 01:49:39]

Ok, but let me do it in separate CL, same reason as above.

+#endif
+
   virtual ~AutocompleteEditView() {}
 };