Support autocompletion for HTMl5 tags:"email", "month" and "tel".

chrome/browser/autofill/credit_card_field.cc

Index: chrome/browser/autofill/credit_card_field.cc
diff --git a/chrome/browser/autofill/credit_card_field.cc b/chrome/browser/autofill/credit_card_field.cc
index f8b4c5e210a81fae47c0ab965321bdccd0ff1c4b..338c486ab58dc2be452234c4896ed6c7d29d5336 100644
--- a/chrome/browser/autofill/credit_card_field.cc
+++ b/chrome/browser/autofill/credit_card_field.cc
@@ -135,14 +135,20 @@ CreditCardField* CreditCardField::Parse(
     if ((!credit_card_field->expiration_month_ ||

[dhollowa, 2011/01/05 03:08:26]

The handling of input type="month" should be split out separately.  We can match
purely on field type in this case.  I.e. pseudocode:

if (*q->form_control_type() == "month") {
  credit_card_field->expiration_month_ = *q++;
} else {
  ...normal logic for text fields, lines 118:148...
}

and then we'll have to add special parsing for month fields that have "month"
type, otherwise callers of |CreditCard::ConvertDate| will be parsing the month
incorrectly.

For example, if you submit a form currently you'll get a DCHECK at the following
stack:


CreditCard::ConvertDate at credit_card.cc:616
CreditCard::SetExpirationMonthFromString at credit_card.cc:487
CreditCard::SetInfo at credit_card.cc:300
PersonalDataManager::ImportFormData at personal_data_manager.cc:172
AutoFillManager::HandleSubmit at autofill_manager.cc:478

[honten.org, 2011/01/05 08:09:09]

Ok,

So can I add new AutoFillType CREDIT_CARD_EXP_YEAR_MONTH? for "month" input
type.
Or should I share CREDIT_CARD_EXP_MONTH? even if "month" input type?

On 2011/01/05 03:08:26, dhollowa wrote:

         credit_card_field->expiration_month_->IsEmpty()) &&
         ParseText(&q, pattern, &credit_card_field->expiration_month_)) {
-      if (is_ecml)
-        pattern = GetEcmlPattern(kEcmlCardExpireYear);
-      else
-        pattern = ASCIIToUTF16("|exp|^/|ccyear|year");
-
-      if (!ParseText(&q, pattern, &credit_card_field->expiration_year_))
-        return NULL;
 
+      // If type="month", year is included into the exipration_month_.
+      // So we don't need another year input field.
+      if (!LowerCaseEqualsASCII(
+          credit_card_field->expiration_month_->form_control_type(), "month")) {
+        if (is_ecml)
+          pattern = GetEcmlPattern(kEcmlCardExpireYear);
+        else
+          pattern = ASCIIToUTF16("|exp|^/|ccyear|year");
+
+        if (!ParseText(&q, pattern, &credit_card_field->expiration_year_)) {
+          return NULL;
+        }
+      }
       continue;
     }
 
@@ -177,7 +183,9 @@ CreditCardField* CreditCardField::Parse(
   // the cvc and date were found independently they are returned.
   if ((credit_card_field->number_ || credit_card_field->verification_) &&
       credit_card_field->expiration_month_ &&
-      credit_card_field->expiration_year_) {
+      (credit_card_field->expiration_year_ ||
+      (LowerCaseEqualsASCII(
+      credit_card_field->expiration_month_->form_control_type(), "month")))) {

[dhollowa, 2011/01/05 03:08:26]

nit: indentation seems off here.  line 188 should be indented in another 4
spaces, and then the "month" param will wrap.

       *iter = q;
       return credit_card_field.release();
   }