Support autocompletion for HTMl5 tags:"email", "month" and "tel".

chrome/browser/autofill/credit_card_field.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/credit_card_field.h"
 
 #include "base/scoped_ptr.h"
 #include "base/string16.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/autofill_field.h"
@@ skipping 114 matching lines @@
     // see if this turns out to be too general.
     //
     // Toolbar Bug 51451: indeed, simply matching "month" is too general for
     //   https://rps.fidelity.com/ftgw/rps/RtlCust/CreatePIN/Init.
     // Instead, we match only words beginning with "month".
     if (is_ecml)
       pattern = GetEcmlPattern(kEcmlCardExpireMonth);
     else
       pattern = ASCIIToUTF16("expir|exp.*month|exp date|ccmonth");
 
     if ((!credit_card_field->expiration_month_ ||

[dhollowa, 2011/01/05 03:08:26]

The handling of input type="month" should be split out separately.  We can match
purely on field type in this case.  I.e. pseudocode:

if (*q->form_control_type() == "month") {
  credit_card_field->expiration_month_ = *q++;
} else {
  ...normal logic for text fields, lines 118:148...
}

and then we'll have to add special parsing for month fields that have "month"
type, otherwise callers of |CreditCard::ConvertDate| will be parsing the month
incorrectly.

For example, if you submit a form currently you'll get a DCHECK at the following
stack:


CreditCard::ConvertDate at credit_card.cc:616
CreditCard::SetExpirationMonthFromString at credit_card.cc:487
CreditCard::SetInfo at credit_card.cc:300
PersonalDataManager::ImportFormData at personal_data_manager.cc:172
AutoFillManager::HandleSubmit at autofill_manager.cc:478

[honten.org, 2011/01/05 08:09:09]

Ok,

So can I add new AutoFillType CREDIT_CARD_EXP_YEAR_MONTH? for "month" input
type.
Or should I share CREDIT_CARD_EXP_MONTH? even if "month" input type?

On 2011/01/05 03:08:26, dhollowa wrote:

         credit_card_field->expiration_month_->IsEmpty()) &&
         ParseText(&q, pattern, &credit_card_field->expiration_month_)) {
-      if (is_ecml)
-        pattern = GetEcmlPattern(kEcmlCardExpireYear);
-      else
-        pattern = ASCIIToUTF16("|exp|^/|ccyear|year");
 
-      if (!ParseText(&q, pattern, &credit_card_field->expiration_year_))
-        return NULL;
+      // If type="month", year is included into the exipration_month_.
+      // So we don't need another year input field.
+      if (!LowerCaseEqualsASCII(
+          credit_card_field->expiration_month_->form_control_type(), "month")) {
+        if (is_ecml)
+          pattern = GetEcmlPattern(kEcmlCardExpireYear);
+        else
+          pattern = ASCIIToUTF16("|exp|^/|ccyear|year");
 
+        if (!ParseText(&q, pattern, &credit_card_field->expiration_year_)) {
+          return NULL;
+        }
+      }
       continue;
     }
 
     if (ParseText(&q, GetEcmlPattern(kEcmlCardExpireDay)))
       continue;
 
     // Some pages (e.g. ExpediaBilling.html) have a "card description"
     // field; we parse this field but ignore it.
     // We also ignore any other fields within a credit card block that
     // start with "card", under the assumption that they are related to
@@ skipping 14 matching lines @@
 
   // On some pages, the user selects a card type using radio buttons
   // (e.g. test page Apple Store Billing.html).  We can't handle that yet,
   // so we treat the card type as optional for now.
   // The existence of a number or cvc in combination with expiration date is
   // a strong enough signal that this is a credit card.  It is possible that
   // the number and name were parsed in a separate part of the form.  So if
   // the cvc and date were found independently they are returned.
   if ((credit_card_field->number_ || credit_card_field->verification_) &&
       credit_card_field->expiration_month_ &&
-      credit_card_field->expiration_year_) {
+      (credit_card_field->expiration_year_ ||
+      (LowerCaseEqualsASCII(
+      credit_card_field->expiration_month_->form_control_type(), "month")))) {

[dhollowa, 2011/01/05 03:08:26]

nit: indentation seems off here.  line 188 should be indented in another 4
spaces, and then the "month" param will wrap.

       *iter = q;
       return credit_card_field.release();
   }
 
   return NULL;
 }
 
 CreditCardField::CreditCardField()
     : cardholder_(NULL),
       cardholder_last_(NULL),
       type_(NULL),
       number_(NULL),
       verification_(NULL),
       expiration_month_(NULL),
       expiration_year_(NULL) {
 }