Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit.h

Issue 6028010: Fixes bug in handling of openning background tabs by way of clicking (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_edit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_edit.h
diff --git a/chrome/browser/autocomplete/autocomplete_edit.h b/chrome/browser/autocomplete/autocomplete_edit.h
index da0625e64d30fa16e39f26ec07414e776d449136..0e66f51887d4e28bfbc479a06b38308be4fcc868 100644
--- a/chrome/browser/autocomplete/autocomplete_edit.h
+++ b/chrome/browser/autocomplete/autocomplete_edit.h
@@ -44,6 +44,8 @@ class AutocompleteEditController {
gfx::NativeView view_gaining_focus) = 0;
// Sent prior to OnAutoCompleteAccept and before the model has been reverted.
+ // This is only invoked if the popup is closed before invoking
+ // OnAutoCompleteAccept.
virtual void OnAutocompleteWillAccept() = 0;
// Commits the suggested text. |typed_text| is the current text showing in the
@@ -253,6 +255,9 @@ class AutocompleteEditModel : public NotificationObserver {
bool has_focus() const { return has_focus_; }
+ // Returns true if the popup is open.
+ bool IsPopupOpen() const;
Peter Kasting 2011/01/05 01:28:11 This makes me really sad. We really need to make
+
// Accessors for keyword-related state (see comments on keyword_ and
// is_keyword_hint_).
std::wstring keyword() const {
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_edit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698