Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 6027004: Revert 69753 - Added group policy for disabling all client-side 3D APIs in Ch... (Closed)

Created:
10 years ago by chase
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 69753 - Added group policy for disabling all client-side 3D APIs in Chromium (in particular, WebGL and Pepper 3D). This has been hooked up through a new command-line argument (--disable-3d-apis) orthogonal to the existing ones, so that further changes to those command line arguments will not accidentally regress the group policy support. Tested in the following ways: - Verified that --disable-3d-apis disables WebGL and Pepper 3D support on Mac OS X. - Verified that specifying the Disable3DAPIs policy via a JSON file disables WebGL on Linux. - Ran unit_tests and verified that there were no failures introduced. BUG=64806 TEST=ConfigurationPolicyPrefStoreBooleanTest Review URL: http://codereview.chromium.org/5991003 TBR=kbr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -70 lines) Patch
M chrome/app/policy/policy_templates.grd View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/app/policy/policy_templates.json View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
MM chrome/browser/policy/configuration_policy_store_interface.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/ui/browser.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/policy_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/policy_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/common/pref_names.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM chrome/common/pref_names.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/sandbox_init_wrapper_mac.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/sandbox_policy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/worker/worker_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
chase
10 years ago (2010-12-20 21:54:48 UTC) #1
Ken Russell (switch to Gerrit)
10 years ago (2010-12-21 01:56:52 UTC) #2
LGTM. Sorry about the build breakage. Being re-landed under
http://codereview.chromium.org/6045003/ .

Powered by Google App Engine
This is Rietveld 408576698