Added group policy for disabling all client-side 3D APIs in Chromium...

Added group policy for disabling all client-side 3D APIs in Chromium
(in particular, WebGL and Pepper 3D). This has been hooked up through
a new command-line argument (--disable-3d-apis) orthogonal to the
existing ones, so that further changes to those command line arguments
will not accidentally regress the group policy support.

Tested in the following ways:
 - Verified that --disable-3d-apis disables WebGL and Pepper 3D
   support on Mac OS X.
 - Verified that specifying the Disable3DAPIs policy via a JSON file
   disables WebGL on Linux.
 - Ran unit_tests and verified that there were no failures introduced.

BUG=64806
TEST=ConfigurationPolicyPrefStoreBooleanTest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69753

[Ken Russell (switch to Gerrit), 2010-12-17 23:13:59]

Reviewers: this bug is targeted at M9 stable, so appreciate reviews at your
earliest convenience.

This CL adds group policy support for disabling Chromium's client-facing 3D
APIs, on request of the security team.

[Mattias Nissler (ping if slow), 2010-12-20 12:25:35]

The policy bits LGTM if you address the two comments I put. I'm not familiar
with the 3D code, so I'll leave reviewing the actual disabling mechanics to
somebody else.

http://codereview.chromium.org/5991003/diff/19001/chrome/browser/policy/manag...
File chrome/browser/policy/managed_prefs_banner_base.cc (right):

http://codereview.chromium.org/5991003/diff/19001/chrome/browser/policy/manag...
chrome/browser/policy/managed_prefs_banner_base.cc:74:
AddUserPref(prefs::kDisable3DAPIs);
Why would we need this? Our policy is to only show the banner if something on
the particular page is inaccessible due to policy being in effect. We don't have
a knob for 3D on the content page AFAICS though.

http://codereview.chromium.org/5991003/diff/19001/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

http://codereview.chromium.org/5991003/diff/19001/chrome/common/pref_names.cc...
chrome/common/pref_names.cc:1160: const char kDisable3DAPIs[] =
"disable_3d_apis";
This file has several sections, please move up into the Profile section.

[Ken Russell (switch to Gerrit), 2010-12-20 20:34:33]

http://codereview.chromium.org/5991003/diff/19001/chrome/browser/policy/manag...
File chrome/browser/policy/managed_prefs_banner_base.cc (right):

http://codereview.chromium.org/5991003/diff/19001/chrome/browser/policy/manag...
chrome/browser/policy/managed_prefs_banner_base.cc:74:
AddUserPref(prefs::kDisable3DAPIs);
On 2010/12/20 12:25:36, Mattias Nissler wrote:
> Why would we need this? Our policy is to only show the banner if something on
> the particular page is inaccessible due to policy being in effect. We don't
have
> a knob for 3D on the content page AFAICS though.

No good reason. I copied it from the example code review at
http://www.chromium.org/developers/how-tos/adding-new-policies but you're right,
there is currently no content setting for 3D content. I've removed this change.

http://codereview.chromium.org/5991003/diff/19001/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

http://codereview.chromium.org/5991003/diff/19001/chrome/common/pref_names.cc...
chrome/common/pref_names.cc:1160: const char kDisable3DAPIs[] =
"disable_3d_apis";
On 2010/12/20 12:25:36, Mattias Nissler wrote:
> This file has several sections, please move up into the Profile section.

Done.

[Vangelis Kokkevis, 2010-12-20 21:08:22]

The 3D side of things looks good.

[Ken Russell (switch to Gerrit), 2010-12-21 01:51:35]

Note that this was reverted in http://codereview.chromium.org/6027004/ due to a
Chromium OS build failure. It is being re-landed under
http://codereview.chromium.org/6045003/ .