Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2323)

Unified Diff: chrome/browser/safe_browsing/protocol_manager.h

Issue 6025005: Consolidate some safe-browsing histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaking Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/protocol_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/protocol_manager.h
diff --git a/chrome/browser/safe_browsing/protocol_manager.h b/chrome/browser/safe_browsing/protocol_manager.h
index 7869e0f4ac666ec836f2a837f6b4af0d7b0f922c..173a49606da932bfbf1e44eef04d03c86daf922b 100644
--- a/chrome/browser/safe_browsing/protocol_manager.h
+++ b/chrome/browser/safe_browsing/protocol_manager.h
@@ -158,6 +158,37 @@ class SafeBrowsingProtocolManager : public URLFetcher::Delegate {
return additional_query_;
}
+ // Enumerate failures for histogramming purposes. DO NOT CHANGE THE
+ // ORDERING OF THESE VALUES.
+ enum ResultType {
+ // 200 response code means that the server recognized the hash
+ // prefix, while 204 is an empty response indicating that the
+ // server did not recognize it.
+ GET_HASH_STATUS_200,
+ GET_HASH_STATUS_204,
+
+ // Subset of successful responses which returned no full hashes.
+ // This includes the 204 case, and also 200 responses for stale
+ // prefixes (deleted at the server but yet deleted on the client).
+ GET_HASH_FULL_HASH_EMPTY,
+
+ // Subset of successful responses for which one or more of the
+ // full hashes matched (should lead to an interstitial).
+ GET_HASH_FULL_HASH_HIT,
+
+ // Subset of successful responses which weren't empty and have no
+ // matches. It means that there was a prefix collision which was
+ // cleared up by the full hashes.
+ GET_HASH_FULL_HASH_MISS,
+
+ // Memory space for histograms is determined by the max. ALWAYS
+ // ADD NEW VALUES BEFORE THIS ONE.
+ GET_HASH_RESULT_MAX
+ };
+
+ // Record a GetHash result.
+ static void RecordGetHashResult(ResultType result_type);
+
protected:
// Constructs a SafeBrowsingProtocolManager for |sb_service| that issues
// network requests using |request_context_getter|. When |disable_auto_update|
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/protocol_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698