Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8836)

Unified Diff: chrome/browser/safe_browsing/protocol_manager.cc

Issue 6025005: Consolidate some safe-browsing histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaking Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/protocol_manager.cc
diff --git a/chrome/browser/safe_browsing/protocol_manager.cc b/chrome/browser/safe_browsing/protocol_manager.cc
index 8e29489e072dd1460f47cd83b8929919fe5ba6d6..69f8583c1d3dcd4615fbf8436d00f632d66cdafe 100644
--- a/chrome/browser/safe_browsing/protocol_manager.cc
+++ b/chrome/browser/safe_browsing/protocol_manager.cc
@@ -125,6 +125,12 @@ SafeBrowsingProtocolManager::SafeBrowsingProtocolManager(
version_ = version_info.Version();
}
+// static
+void SafeBrowsingProtocolManager::RecordGetHashResult(ResultType result_type) {
+ UMA_HISTOGRAM_ENUMERATION("SB2.GetHashResult", result_type,
+ GET_HASH_RESULT_MAX);
+}
+
SafeBrowsingProtocolManager::~SafeBrowsingProtocolManager() {
// Delete in-progress SafeBrowsing requests.
STLDeleteContainerPairFirstPointers(hash_requests_.begin(),
@@ -225,9 +231,9 @@ void SafeBrowsingProtocolManager::OnURLFetchComplete(
// For tracking our GetHash false positive (204) rate, compared to real
// (200) responses.
if (response_code == 200)
- UMA_HISTOGRAM_COUNTS("SB2.GetHash200", 1);
+ RecordGetHashResult(GET_HASH_STATUS_200);
else
- UMA_HISTOGRAM_COUNTS("SB2.GetHash204", 1);
+ RecordGetHashResult(GET_HASH_STATUS_204);
can_cache = true;
gethash_error_count_ = 0;
gethash_back_off_mult_ = 1;
« no previous file with comments | « chrome/browser/safe_browsing/protocol_manager.h ('k') | chrome/browser/safe_browsing/safe_browsing_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698