Consider the popup window position when the window shows upward. This patch depends on WebKit patch.

chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Index: chrome/browser/renderer_host/render_widget_host_view_gtk.cc
diff --git a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
index 2526816da26ed403a6d282186dc29ba6bb793dec..c9e564ec78b915cc435b335d0616aba81351c218 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
+++ b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
@@ -560,12 +560,20 @@ void RenderWidgetHostViewGtk::WasHidden() {
 }
 
 void RenderWidgetHostViewGtk::SetSize(const gfx::Size& size) {
+  gfx::Rect rect = GetViewBounds();

[Evan Stade, 2011/02/16 22:03:17]

are you sure this works? I think the origin of GetViewBounds is not in screen
coordinates

[Peter Kasting, 2011/02/16 22:04:21]

It's supposed to be, per the header comments.  The implementation is in this
file below here, so you can double-check it.

[honten.org, 2011/02/16 22:49:59]

Yes, GetViewBounds() actually returns screen coordinate. I confirmed.

On 2011/02/16 22:04:21, Peter Kasting wrote:

[honten.org, 2011/02/17 08:45:37]

Oops, I was wrong.

After I double-checked it, I noticed GetViewBounds() had a bug in RWHVGtk.

We should use 
  gtk_widget_get_pointer(view_.get(), &x, &y)
instead of
GtkAllocation* alloc = &view_.get()->allocation;
in GetViewBounds().

I'll fix it.

On 2011/02/16 22:49:59, honten wrote:

[honten.org, 2011/02/18 09:11:26]

Done.

+  rect.set_size(size);
+  SetBounds(rect);
+}
+
+void RenderWidgetHostViewGtk::SetBounds(const gfx::Rect& rect) {
   // This is called when webkit has sent us a Move message.
-  int width = std::min(size.width(), kMaxWindowWidth);
-  int height = std::min(size.height(), kMaxWindowHeight);
+  int width = std::min(rect.width(), kMaxWindowWidth);
+  int height = std::min(rect.height(), kMaxWindowHeight);
   if (IsPopup()) {
     // We're a popup, honor the size request.
     gtk_widget_set_size_request(view_.get(), width, height);
+    gtk_window_move(GTK_WINDOW(gtk_widget_get_parent(view_.get())),
+                    rect.x(), rect.y());
   } else {

[honten.org, 2011/02/17 08:45:37]

As Peter pointed out, I should move gtk_window_move() after if() else() close.

But only if the parent widget is window, we can call gtk_window_move() as
following,
GtkWidget* parent_widget = gtk_widget_get_parent(view_.get()); 
if (GTK_IS_WINDOW(parent_widget)) 
  gtk_window_move(GTK_WINDOW(parent_widget), rect.x(), rect.y()); 

[honten.org, 2011/02/18 09:11:26]

Done.

 #if defined(TOOLKIT_VIEWS)
     // TOOLKIT_VIEWS' resize logic flow matches windows. so we go ahead and