Consider the popup window position when the window shows upward. This patch depends on WebKit patch.

chrome/browser/renderer_host/render_widget_host_view_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_widget_host_view_gtk.h"
 
 // If this gets included after the gtk headers, then a bunch of compiler
 // errors happen because of a "#define Status int" in Xlib.h, which interacts
 // badly with net::URLRequestStatus::Status.
 #include "chrome/common/render_messages.h"
@@ skipping 542 matching lines @@
   // ignore them so we don't re-allocate the backing store.  We will paint
   // everything again when we become selected again.
   is_hidden_ = true;
 
   // If we have a renderer, then inform it that we are being hidden so it can
   // reduce its resource utilization.
   GetRenderWidgetHost()->WasHidden();
 }
 
 void RenderWidgetHostViewGtk::SetSize(const gfx::Size& size) {
+  gfx::Rect rect = GetViewBounds();

[Evan Stade, 2011/02/16 22:03:17]

are you sure this works? I think the origin of GetViewBounds is not in screen
coordinates

[Peter Kasting, 2011/02/16 22:04:21]

It's supposed to be, per the header comments.  The implementation is in this
file below here, so you can double-check it.

[honten.org, 2011/02/16 22:49:59]

Yes, GetViewBounds() actually returns screen coordinate. I confirmed.

On 2011/02/16 22:04:21, Peter Kasting wrote:

[honten.org, 2011/02/17 08:45:37]

Oops, I was wrong.

After I double-checked it, I noticed GetViewBounds() had a bug in RWHVGtk.

We should use 
  gtk_widget_get_pointer(view_.get(), &x, &y)
instead of
GtkAllocation* alloc = &view_.get()->allocation;
in GetViewBounds().

I'll fix it.

On 2011/02/16 22:49:59, honten wrote:

[honten.org, 2011/02/18 09:11:26]

Done.

+  rect.set_size(size);
+  SetBounds(rect);
+}
+
+void RenderWidgetHostViewGtk::SetBounds(const gfx::Rect& rect) {
   // This is called when webkit has sent us a Move message.
-  int width = std::min(size.width(), kMaxWindowWidth);
-  int height = std::min(size.height(), kMaxWindowHeight);
+  int width = std::min(rect.width(), kMaxWindowWidth);
+  int height = std::min(rect.height(), kMaxWindowHeight);
   if (IsPopup()) {
     // We're a popup, honor the size request.
     gtk_widget_set_size_request(view_.get(), width, height);
+    gtk_window_move(GTK_WINDOW(gtk_widget_get_parent(view_.get())),
+                    rect.x(), rect.y());
   } else {

[honten.org, 2011/02/17 08:45:37]

As Peter pointed out, I should move gtk_window_move() after if() else() close.

But only if the parent widget is window, we can call gtk_window_move() as
following,
GtkWidget* parent_widget = gtk_widget_get_parent(view_.get()); 
if (GTK_IS_WINDOW(parent_widget)) 
  gtk_window_move(GTK_WINDOW(parent_widget), rect.x(), rect.y()); 

[honten.org, 2011/02/18 09:11:26]

Done.

 #if defined(TOOLKIT_VIEWS)
     // TOOLKIT_VIEWS' resize logic flow matches windows. so we go ahead and
     // size the widget.  In GTK+, the size of the widget is determined by its
     // children.
     gtk_widget_set_size_request(view_.get(), width, height);
 #endif
   }
   // Update the size of the RWH.
   if (requested_size_.width() != width ||
       requested_size_.height() != height) {
@@ skipping 541 matching lines @@
 }
 
 // static
 RenderWidgetHostView*
     RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView(
         gfx::NativeView widget) {
   gpointer user_data = g_object_get_data(G_OBJECT(widget),
                                          kRenderWidgetHostViewKey);
   return reinterpret_cast<RenderWidgetHostView*>(user_data);
 }