Consider the popup window position when the window shows upward. This patch depends on WebKit patch.

chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Index: chrome/browser/renderer_host/render_widget_host_view_gtk.cc
diff --git a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
index aa43529c2f93762263070a8e73ea0c8ff3cd5a95..42bb9fea1fb9803c168b1c980023d3346cc3f9c9 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
+++ b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
@@ -567,6 +567,23 @@ void RenderWidgetHostViewGtk::SetSize(const gfx::Size& size) {
   }
 }
 
+void RenderWidgetHostViewGtk::MoveTo(const gfx::Point& origin) {
+  // This is called when webkit has sent us a Move message.
+  if (IsPopup()) {
+    // We're a popup, honor the size request.
+    gtk_window_move(GTK_WINDOW(gtk_widget_get_parent(view_.get())),
+                    origin.x(), origin.y());
+  } else {
+#if defined(TOOLKIT_VIEWS)
+    // TOOLKIT_VIEWS' resize logic flow matches windows. so we go ahead and

[Evan Stade, 2011/01/22 01:32:05]

are you sure this is necessary?

[honten.org, 2011/01/22 01:53:19]

Actually I'm not sure.

I don't know how to enable TOOLKET_VIEWS, but I mimic it from the prev function.

On 2011/01/22 01:32:05, Evan Stade wrote:

[honten.org, 2011/01/23 04:46:35]

Evan,

I tried to make sure after turning on TOOLKIT_VIES, but I failed to build with
the flag because of link error in the current source code.

Right now, I turned on as following,
 export GYP_DEFINES="toolkit_views=1" 
but still don't know what is difference between enabled and disabled.

Could you tell me?

Thanks,

On 2011/01/22 01:53:19, honten wrote:

[honten.org, 2011/01/23 08:28:55]

Evan,

I made sure we need it.

On 2011/01/23 04:46:35, honten wrote:

[Evan Stade, 2011/01/24 23:08:02]

what does this mean? If you just copied it from the other function, I'm almost
certain we don't need it. The comment talks about sizing the widget. Sizing and
moving are different things.

+    // size the widget.  In GTK+, the size of the widget is determined by its
+    // children.
+    gtk_window_move(GTK_WINDOW(gtk_widget_get_parent(view_.get())),
+        origin.x(), origin.y());
+#endif
+  }
+}
+
 gfx::NativeView RenderWidgetHostViewGtk::GetNativeView() {
   return view_.get();
 }