Consider the popup window position when the window shows upward. This patch depends on WebKit patch.

chrome/browser/renderer_host/render_widget_host_view_gtk.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_widget_host_view_gtk.h"
 
 // If this gets included after the gtk headers, then a bunch of compiler
 // errors happen because of a "#define Status int" in Xlib.h, which interacts
 // badly with URLRequestStatus::Status.
 #include "chrome/common/render_messages.h"
@@ skipping 549 matching lines @@
 #endif
   }
   // Update the size of the RWH.
   if (requested_size_.width() != width ||
       requested_size_.height() != height) {
     requested_size_ = gfx::Size(width, height);
     host_->WasResized();
   }
 }
 
+void RenderWidgetHostViewGtk::MoveTo(const gfx::Point& origin) {
+  // This is called when webkit has sent us a Move message.
+  if (IsPopup()) {
+    // We're a popup, honor the size request.
+    gtk_window_move(GTK_WINDOW(gtk_widget_get_parent(view_.get())),
+                    origin.x(), origin.y());
+  } else {
+#if defined(TOOLKIT_VIEWS)
+    // TOOLKIT_VIEWS' resize logic flow matches windows. so we go ahead and

[Evan Stade, 2011/01/22 01:32:05]

are you sure this is necessary?

[honten.org, 2011/01/22 01:53:19]

Actually I'm not sure.

I don't know how to enable TOOLKET_VIEWS, but I mimic it from the prev function.

On 2011/01/22 01:32:05, Evan Stade wrote:

[honten.org, 2011/01/23 04:46:35]

Evan,

I tried to make sure after turning on TOOLKIT_VIES, but I failed to build with
the flag because of link error in the current source code.

Right now, I turned on as following,
 export GYP_DEFINES="toolkit_views=1" 
but still don't know what is difference between enabled and disabled.

Could you tell me?

Thanks,

On 2011/01/22 01:53:19, honten wrote:

[honten.org, 2011/01/23 08:28:55]

Evan,

I made sure we need it.

On 2011/01/23 04:46:35, honten wrote:

[Evan Stade, 2011/01/24 23:08:02]

what does this mean? If you just copied it from the other function, I'm almost
certain we don't need it. The comment talks about sizing the widget. Sizing and
moving are different things.

+    // size the widget.  In GTK+, the size of the widget is determined by its
+    // children.
+    gtk_window_move(GTK_WINDOW(gtk_widget_get_parent(view_.get())),
+        origin.x(), origin.y());
+#endif
+  }
+}
+
 gfx::NativeView RenderWidgetHostViewGtk::GetNativeView() {
   return view_.get();
 }
 
 void RenderWidgetHostViewGtk::MovePluginWindows(
     const std::vector<webkit_glue::WebPluginGeometry>& moves) {
   for (size_t i = 0; i < moves.size(); ++i) {
     plugin_container_manager_.MovePluginContainer(moves[i]);
   }
 }
@@ skipping 487 matching lines @@
 }
 
 // static
 RenderWidgetHostView*
     RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView(
         gfx::NativeView widget) {
   gpointer user_data = g_object_get_data(G_OBJECT(widget),
                                          kRenderWidgetHostViewKey);
   return reinterpret_cast<RenderWidgetHostView*>(user_data);
 }