Ensure that when using False Start + client auth, bad client certificates are not cached

net/socket/socket_test_util.cc

Index: net/socket/socket_test_util.cc
diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc
index d88399d489dc85ce4565fb6f9e8e296e70459ab9..a7bebed41d8d257588265780a909d937a30e79e7 100644
--- a/net/socket/socket_test_util.cc
+++ b/net/socket/socket_test_util.cc
@@ -15,6 +15,7 @@
 #include "net/base/address_family.h"
 #include "net/base/auth.h"
 #include "net/base/host_resolver_proc.h"
+#include "net/base/ssl_cert_request_info.h"
 #include "net/base/ssl_info.h"
 #include "net/http/http_network_session.h"
 #include "net/http/http_request_headers.h"
@@ -531,6 +532,18 @@ void MockSSLClientSocket::GetSSLInfo(net::SSLInfo* ssl_info) {
   ssl_info->Reset();
 }
 
+void MockSSLClientSocket::GetSSLCertRequestInfo(
+    net::SSLCertRequestInfo* cert_request_info) {
+  DCHECK(cert_request_info);
+  if (data_->cert_request_info) {
+    cert_request_info->host_and_port =
+        data_->cert_request_info->host_and_port;
+    cert_request_info->client_certs = data_->cert_request_info->client_certs;

[wtc, 2011/01/12 00:21:09]

Would it be better to just do a struct copy here?
    *cert_request_info = *data_->cert_request_info;

[Ryan Sleevi, 2011/01/12 00:40:07]

Yes. However, because SSLCertRequestInfo is RefCountedThreadSafe, the implicit
assignment operator is private (because RefCountedThreadSafe operator= is
private). Looking at the usage in net/, it probably doesn't need to be
refcounted at all, since most of the layers that use the SSLCertRequestInfo make
copies before returning to the caller (for safety reasons, presumably, since the
request info may change)

This was the cause of my Mac compile woes in the the earlier patchset, and
rather than shoe-horn in more changes, I decided it was better to submit a
separate CL and comprehensively address it. It also didn't seem appropriate to
use this CL to bring in that change, and I wanted to get this landed before M10
(and M9), rather than introduce another dependency.

+  } else {
+    cert_request_info->Reset();
+  }
+}
+
 SSLClientSocket::NextProtoStatus MockSSLClientSocket::GetNextProto(
     std::string* proto) {
   *proto = data_->next_proto;