Ensure that when using False Start + client auth, bad client certificates are not cached

net/socket/socket_test_util.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/socket_test_util.h"
 
 #include <algorithm>
 #include <vector>
 
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
 #include "base/time.h"
 #include "net/base/address_family.h"
 #include "net/base/auth.h"
 #include "net/base/host_resolver_proc.h"
+#include "net/base/ssl_cert_request_info.h"
 #include "net/base/ssl_info.h"
 #include "net/http/http_network_session.h"
 #include "net/http/http_request_headers.h"
 #include "net/http/http_response_headers.h"
 #include "net/socket/client_socket_pool_histograms.h"
 #include "net/socket/socket.h"
 #include "net/socket/ssl_host_info.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #define NET_TRACE(level, s)   DLOG(level) << s << __FUNCTION__ << "() "
@@ skipping 496 matching lines @@
 
 int MockSSLClientSocket::Write(net::IOBuffer* buf, int buf_len,
                                net::CompletionCallback* callback) {
   return transport_->socket()->Write(buf, buf_len, callback);
 }
 
 void MockSSLClientSocket::GetSSLInfo(net::SSLInfo* ssl_info) {
   ssl_info->Reset();
 }
 
+void MockSSLClientSocket::GetSSLCertRequestInfo(
+    net::SSLCertRequestInfo* cert_request_info) {
+  DCHECK(cert_request_info);
+  if (data_->cert_request_info) {
+    cert_request_info->host_and_port =
+        data_->cert_request_info->host_and_port;
+    cert_request_info->client_certs = data_->cert_request_info->client_certs;

[wtc, 2011/01/12 00:21:09]

Would it be better to just do a struct copy here?
    *cert_request_info = *data_->cert_request_info;

[Ryan Sleevi, 2011/01/12 00:40:07]

Yes. However, because SSLCertRequestInfo is RefCountedThreadSafe, the implicit
assignment operator is private (because RefCountedThreadSafe operator= is
private). Looking at the usage in net/, it probably doesn't need to be
refcounted at all, since most of the layers that use the SSLCertRequestInfo make
copies before returning to the caller (for safety reasons, presumably, since the
request info may change)

This was the cause of my Mac compile woes in the the earlier patchset, and
rather than shoe-horn in more changes, I decided it was better to submit a
separate CL and comprehensively address it. It also didn't seem appropriate to
use this CL to bring in that change, and I wanted to get this landed before M10
(and M9), rather than introduce another dependency.

+  } else {
+    cert_request_info->Reset();
+  }
+}
+
 SSLClientSocket::NextProtoStatus MockSSLClientSocket::GetNextProto(
     std::string* proto) {
   *proto = data_->next_proto;
   return data_->next_proto_status;
 }
 
 bool MockSSLClientSocket::was_npn_negotiated() const {
   if (is_npn_state_set_)
     return new_npn_value_;
   return data_->was_npn_negotiated;
@@ skipping 733 matching lines @@
 
 const char kSOCKS5OkRequest[] =
     { 0x05, 0x01, 0x00, 0x03, 0x04, 'h', 'o', 's', 't', 0x00, 0x50 };
 const int kSOCKS5OkRequestLength = arraysize(kSOCKS5OkRequest);
 
 const char kSOCKS5OkResponse[] =
     { 0x05, 0x00, 0x00, 0x01, 127, 0, 0, 1, 0x00, 0x50 };
 const int kSOCKS5OkResponseLength = arraysize(kSOCKS5OkResponse);
 
 }  // namespace net