Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 6016002: touch: Fix switching focus among fields in webpages. (Closed)

Created:
10 years ago by sadrul
Modified:
9 years, 6 months ago
Reviewers:
rjkroege, Jay Civelli, sky
CC:
chromium-reviews
Visibility:
Public.

Description

touch: Fix switching focus among fields in webpages. If Tab is pressed, then the RootView needs to process it first, because the focus-manager will move the focus to the next focusable view, without letting the currently focused view process it (which means, for example, tab-ing to move focus between fields/links in a RenderWidgetHostViewViews won't work). For all other keys, let the focus manager process it first so that the keyboard accelerators can be triggered. BUG=pressing tab in a textfield in a touch-build doesn't move focus out of it. TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M views/focus/accelerator_handler_touch.cc View 1 chunk +18 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
10 years ago (2010-12-18 05:06:39 UTC) #1
rjkroege
LGTM.
10 years ago (2010-12-20 19:21:17 UTC) #2
sky
Could you get Jay to review this? Thanks, -Scott
10 years ago (2010-12-20 20:58:29 UTC) #3
sadrul
PTAL!
10 years ago (2010-12-21 18:33:33 UTC) #4
Jay Civelli
10 years ago (2010-12-21 18:42:10 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698