touch: Fix switching focus among fields in webpages.

views/focus/accelerator_handler_touch.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/focus/accelerator_handler.h"
 
 #include <bitset>
 #include <gtk/gtk.h>
 #if defined(HAVE_XINPUT2)
 #include <X11/extensions/XInput2.h>
@@ skipping 135 matching lines @@
     XGenericEventCookie* cookie = &xev->xcookie;
     XIDeviceEvent* xiev = static_cast<XIDeviceEvent*>(cookie->data);
     xwindow = xiev->event;
   }
 #endif
 
   GdkWindow* gwind = gdk_window_lookup_for_display(gdisp, xwindow);
 
   if (RootView* root = FindRootViewForGdkWindow(gwind)) {
     switch (xev->type) {
-      case KeyPress:
-      case KeyRelease: {
+      case KeyPress: {
+        // If Tab is pressed, then the RootView needs to process it first,
+        // because the focus-manager will move the focus to the next focusable
+        // view, without letting the currently focused view process it (which
+        // means, for example, tab-ing to move focus between fields/links in a
+        // RenderWidgetHostViewViews won't work). For all other keys, let the
+        // focus manager process it first so that the keyboard accelerators can
+        // be triggered.
         KeyEvent keyev(xev);
+        FocusManager* focus_manager = root->GetFocusManager();
+        if (FocusManager::IsTabTraversalKeyEvent(keyev)) {
+          return root->ProcessKeyEvent(keyev) ||
+              (focus_manager && !focus_manager->OnKeyEvent(keyev));
+        } else {
+          return (focus_manager && !focus_manager->OnKeyEvent(keyev)) ||
+              root->ProcessKeyEvent(keyev);
+        }
+      }
 
-        // If it's a keypress, check to see if it triggers an accelerator.
-        if (xev->type == KeyPress) {
-          FocusManager* focus_manager = root->GetFocusManager();
-          if (focus_manager && !focus_manager->OnKeyEvent(keyev))
-            return true;
-        }
-
-        return root->ProcessKeyEvent(keyev);
-      }
+      case KeyRelease:
+        return root->ProcessKeyEvent(KeyEvent(xev));
 
       case ButtonPress:
       case ButtonRelease: {
         if (xev->xbutton.button == 4 || xev->xbutton.button == 5) {
           // Scrolling the wheel triggers button press/release events.
           MouseWheelEvent wheelev(xev);
           return root->ProcessMouseWheelEvent(wheelev);
         } else {
           MouseEvent mouseev(xev);
           if (xev->type == ButtonPress) {
@@ skipping 41 matching lines @@
 }
 
 base::MessagePumpGlibXDispatcher::DispatchStatus AcceleratorHandler::Dispatch(
     XEvent* xev) {
   return DispatchXEvent(xev) ?
       base::MessagePumpGlibXDispatcher::EVENT_PROCESSED :
       base::MessagePumpGlibXDispatcher::EVENT_IGNORED;
 }
 
 }  // namespace views