src/ia32/regexp-macro-assembler-ia32.cc - Issue 6015011: Use the macro assembler Set instead of explicit xor for clearing registers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/regexp-macro-assembler-ia32.cc

Issue 6015011: Use the macro assembler Set instead of explicit xor for clearing registers. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/regexp-macro-assembler-ia32.cc

===================================================================

--- src/ia32/regexp-macro-assembler-ia32.cc (revision 6129)

+++ src/ia32/regexp-macro-assembler-ia32.cc (working copy)

@@ -652,7 +652,7 @@

void RegExpMacroAssemblerIA32::Fail() {

ASSERT(FAILURE == 0); // Return value for failure is zero.

- __ xor_(eax, Operand(eax)); // zero eax.

+ __ Set(eax, Immediate(0));

__ jmp(&exit_label_);

}

« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/x64/assembler-x64.cc » ('j') | no next file with comments »