Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 6012006: Revert 68944 - Revert "Add named testing interface." (Closed)

Created:
10 years ago by Nirnimesh
Modified:
9 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, amit, darin-cc_chromium.org, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Revert 68944 - Revert "Add named testing interface." Reverting the revert of named interface CL. Followup CL which addresses Pawel's comments is up at http://codereview.chromium.org/5967003/ http://src.chromium.org/viewvc/chrome?view=rev&revision=67300 The change has been approved conditionally, i.e. if the outstanding review comments are handled in a follow-up as the top priority. Two weeks have passed, and I have not seen the follow-up. It is risky to keep this change in the tree, as it is already non-trivial to revert. Conflicts: chrome/browser/automation/automation_provider.cc chrome/test/ui/named_interface_uitest.cc ipc/ipc_channel_posix.cc TBR=nirnimesh BUG=chromium-os:8512 TEST=none Review URL: http://codereview.chromium.org/5707006 TBR=phajdan.jr@chromium.org BUG=chromium-os:8512 TEST=ui_tests --gtest_filter=NamedInterfaceTest.FLAKY_BasicNamedInterface Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+439 lines, -85 lines) Patch
M chrome/browser/automation/automation_provider.h View 4 chunks +20 lines, -4 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 4 chunks +47 lines, -14 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.cc View 3 chunks +15 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 4 chunks +9 lines, -0 lines 0 comments Download
M chrome/common/automation_constants.h View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/common/automation_constants.cc View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/test/automation/automation_proxy.h View 3 chunks +11 lines, -7 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 3 chunks +32 lines, -3 lines 0 comments Download
A chrome/test/automation/proxy_launcher.h View 1 chunk +78 lines, -0 lines 0 comments Download
A chrome/test/automation/proxy_launcher.cc View 1 chunk +75 lines, -0 lines 0 comments Download
A chrome/test/ui/named_interface_uitest.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M chrome/test/ui/ui_test.h View 8 chunks +19 lines, -8 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 9 chunks +39 lines, -21 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome_frame/chrome_frame_automation.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome_frame/test/automation_client_mock.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/net/test_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Paweł Hajdan Jr.
9 years, 11 months ago (2011-01-05 20:14:54 UTC) #1
OK. Please remember to hit Publish+Mail for TBR reviews.

Powered by Google App Engine
This is Rietveld 408576698