Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5707006: Revert "Add named testing interface." (Closed)

Created:
10 years ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, amit, jam, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Revert "Add named testing interface." http://src.chromium.org/viewvc/chrome?view=rev&revision=67300 The change has been approved conditionally, i.e. if the outstanding review comments are handled in a follow-up as the top priority. Two weeks have passed, and I have not seen the follow-up. It is risky to keep this change in the tree, as it is already non-trivial to revert. Conflicts: chrome/browser/automation/automation_provider.cc chrome/test/ui/named_interface_uitest.cc ipc/ipc_channel_posix.cc TBR=nirnimesh BUG=chromium-os:8512 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -452 lines) Patch
M chrome/browser/automation/automation_provider.h View 4 chunks +4 lines, -20 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 4 chunks +14 lines, -47 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.cc View 3 chunks +8 lines, -15 lines 0 comments Download
M chrome/chrome_tests.gypi View 4 chunks +0 lines, -9 lines 0 comments Download
M chrome/common/automation_constants.h View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/common/automation_constants.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/test/automation/automation_proxy.h View 3 chunks +7 lines, -11 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 3 chunks +3 lines, -32 lines 0 comments Download
D chrome/test/automation/proxy_launcher.h View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/test/automation/proxy_launcher.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/test/ui/named_interface_uitest.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M chrome/test/ui/ui_test.h View 8 chunks +8 lines, -19 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 9 chunks +21 lines, -39 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 2 chunks +1 line, -5 lines 0 comments Download
M chrome_frame/chrome_frame_automation.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M chrome_frame/test/automation_client_mock.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/net/test_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel.h View 1 chunk +1 line, -3 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Paweł Hajdan Jr.
10 years ago (2010-12-11 12:17:50 UTC) #1 
TBR

I'm sorry for this revert.

Powered by Google App Engine
This is Rietveld 408576698