Issue 601082: enter_chroot: allow depot_tools to fail to mount

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 601082: enter_chroot: allow depot_tools to fail to mount (Closed)

Created:
10 years, 10 months ago by adlr

Modified:
9 years ago

Reviewers:
Alexey Marinichev

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

enter_chroot: allow depot_tools to fail to mount

Patch Set 2 : fixes for review #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/scripts/enter_chroot.sh	View	1	1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Alexey Marinichev

http://codereview.chromium.org/601082/diff/1/2 File src/scripts/enter_chroot.sh (right): http://codereview.chromium.org/601082/diff/1/2#newcode125 src/scripts/enter_chroot.sh:125: sudo mount --bind "$DEPOT_TOOLS" "$MOUNTED_PATH" || true In this ...

10 years, 10 months ago (2010-02-16 21:37:25 UTC) #2

Alexey Marinichev

I misunderstood. I thought chromium build will fail, but I'm told it will simply download ...

10 years, 10 months ago (2010-02-16 21:46:13 UTC) #3

Alexey Marinichev

10 years, 10 months ago (2010-02-16 22:13:17 UTC) #5

http://codereview.chromium.org/601082/diff/1003/3002
File src/scripts/enter_chroot.sh (right):

http://codereview.chromium.org/601082/diff/1003/3002#newcode126
src/scripts/enter_chroot.sh:126: echo "depot_tools failed to mount. This may
impact chromium build"
Maybe we could add something like "check your NFS permissions".  LGTM otherwise.

Expand Messages | Collapse Messages

Issue 601082: enter_chroot: allow depot_tools to fail to mount (Closed)

Description

Patch Set 1 #

Patch Set 2 : fixes for review #

Messages