enter_chroot: allow depot_tools to fail to mount

src/scripts/enter_chroot.sh

 #!/bin/bash
 
 # Copyright (c) 2009 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Script to enter the chroot environment
 
 # Load common constants.  This should be the first executable line.
 # The path to common.sh should be relative to your script's location.
@@ skipping 104 matching lines @@
       fi
     fi
 
     MOUNTED_PATH="$(readlink -f "${FLAGS_chroot}${INNER_DEPOT_TOOLS_ROOT}")"
     if [ -z "$(mount | grep -F "on $MOUNTED_PATH")" ]
     then
       if [ $(which gclient 2>/dev/null) ]; then
         echo "Mounting depot_tools"
         DEPOT_TOOLS=$(dirname $(which gclient) )
         mkdir -p "$MOUNTED_PATH"
-        sudo mount --bind "$DEPOT_TOOLS" "$MOUNTED_PATH"
+        if ! sudo mount --bind "$DEPOT_TOOLS" "$MOUNTED_PATH"; then
+          echo "depot_tools failed to mount. This may impact chromium build"

[Alexey Marinichev, 2010/02/16 22:13:17]

Maybe we could add something like "check your NFS permissions".  LGTM otherwise.

+        fi
       fi
     fi
   ) 200>>"$LOCKFILE"
 }
 
 function teardown_env {
   # Only teardown if we're the last enter_chroot to die
 
   (
     flock 200
@@ skipping 79 matching lines @@
 
 # Run command or interactive shell.  Also include the non-chrooted path to
 # the source trunk for scripts that may need to print it (e.g.
 # build_image.sh).
 sudo chroot "$FLAGS_chroot" sudo -i -u $USER $CHROOT_PASSTHRU \
   EXTERNAL_TRUNK_PATH="${FLAGS_trunk}" LANG=C "$@"
 
 # Remove trap and explicitly unmount
 trap - EXIT
 teardown_env