Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 601057: Remove pixel size from about:version. (Closed)

Created:
10 years, 10 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Remove pixel size from about:version. It was needless, and causes ugly wrapping if you don't have the exact fonts specified. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38898

Patch Set 1 #

Patch Set 2 : nowrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/about_version.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
Though you may not remember it, apparently you are the author of this file!
10 years, 10 months ago (2010-02-12 16:00:42 UTC) #1
Evan Martin
On 2010/02/12 16:00:42, Evan Martin wrote: > Though you may not remember it, apparently you ...
10 years, 10 months ago (2010-02-12 16:02:02 UTC) #2
Erik does not do reviews
10 years, 10 months ago (2010-02-12 16:33:37 UTC) #3
LGTM.  Thanks for the cleanup.  I'm surprised this file has lasted as long
as it has.  I think that may have been the oldest bit of code I wrote in
Chrome outside of the Omaha stuff.

Erik



On Fri, Feb 12, 2010 at 8:00 AM, <evan@chromium.org> wrote:

> Reviewers: Erik Kay,
>
> Message:
> Though you may not remember it, apparently you are the author of this file!
>
> Description:
> Remove pixel size from about:version.
>
> It was needless, and causes ugly wrapping if you don't have the
> exact fonts specified.
>
> Please review this at http://codereview.chromium.org/601057
>
> Affected files:
>  M chrome/browser/resources/about_version.html
>
>
> Index: chrome/browser/resources/about_version.html
> diff --git a/chrome/browser/resources/about_version.html
> b/chrome/browser/resources/about_version.html
> index
>
cdc52350e88ff2d829855ab413e4060793f86f85..af3b8adf49ec612eb3336a5b73ec5cd21dc41478
> 100644
> --- a/chrome/browser/resources/about_version.html
> +++ b/chrome/browser/resources/about_version.html
> @@ -28,7 +28,7 @@ about:version template page
>       .label {
>         font-weight: bold;
>         text-align: right;
> -        width: 120px;
> +        white-space: nowrap;
>         padding-right: 5px;
>         font-size: 0.9em;
>         border-right: 0px solid black;
>
>
>

Powered by Google App Engine
This is Rietveld 408576698