Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 601044: Updating status on three tests... (Closed)

Created:
10 years, 10 months ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
dr
CC:
finnur+watch_chromium.org
Visibility:
Public.

Description

Updating status on three tests: Someone changed FindInPagePrematureEnd from DISABLED to FAILS. However, it is not expected to pass until we fix 11761 so we don't need to run it until then. Marking it back as DISABLED. NoIncognitoPrepopulate was failing because the infrastructure was laggy (the simple act of launching a page in incognito could take up to a minute). I can no longer repro the error, so I think the problem is gone. Back in June, ActivateLinkNavigatesPage got marked as DISABLED (because it crashed occasionally), with a bug filed against no-one, so I have no crashdump or try bot logs nor any idea what the state of it is. Marking as enabled to see if it is still a problem. It passes locally. BUG=45594, 40948 TEST=These are tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59930

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M chrome/browser/find_bar_host_browsertest.cc View 3 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Finnur
10 years, 10 months ago (2010-02-11 18:57:24 UTC) #1
Finnur
10 years, 3 months ago (2010-09-20 12:09:50 UTC) #2
dr
10 years, 3 months ago (2010-09-20 12:14:08 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698