Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: chrome/browser/find_bar_host_browsertest.cc

Issue 601044: Updating status on three tests... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/find_bar_host_browsertest.cc
===================================================================
--- chrome/browser/find_bar_host_browsertest.cc (revision 59922)
+++ chrome/browser/find_bar_host_browsertest.cc (working copy)
@@ -502,7 +502,9 @@
}
// This tests bug 11761: FindInPage terminates search prematurely.
-IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FAILS_FindInPagePrematureEnd) {
+// This test is not expected to pass until bug 11761 is fixed.
+IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
+ DISABLED_FindInPagePrematureEnd) {
ASSERT_TRUE(test_server()->Start());
// First we navigate to our special focus tracking page.
@@ -983,9 +985,6 @@
// linux views. Investigate and fix. http://crbug.com/40948
#if defined(OS_LINUX) && defined(TOOLKIT_VIEWS)
#define MAYBE_NoIncognitoPrepopulate DISABLED_NoIncognitoPrepopulate
-#elif defined (OS_WIN)
-// On windows, this test is flaky. http://crbug.com/40948
-#define MAYBE_NoIncognitoPrepopulate FLAKY_NoIncognitoPrepopulate
#else
#define MAYBE_NoIncognitoPrepopulate NoIncognitoPrepopulate
#endif
@@ -1058,15 +1057,8 @@
EXPECT_EQ(ASCIIToUTF16("page"), GetFindBarTextForBrowser(browser()));
}
-// See http://crbug.com/45594. On Windows, it crashes sometimes.
-#if defined(OS_WIN)
-#define MAYBE_ActivateLinkNavigatesPage DISABLED_ActivateLinkNavigatesPage
-#else
-#define MAYBE_ActivateLinkNavigatesPage ActivateLinkNavigatesPage
-#endif
// This makes sure that dismissing the find bar with kActivateSelection works.
-IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
- MAYBE_ActivateLinkNavigatesPage) {
+IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, ActivateLinkNavigatesPage) {
ASSERT_TRUE(test_server()->Start());
// First we navigate to our test content.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698