Adding more verifications to recenthistorypage test

After I watch running test carefully, I found that history page option starts coming into the omnibox, but test count comparison wasn't catching that. So now checking history page option in each waituntil iteration.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70758

[Nirnimesh, 2011-01-06 02:09:17]

Please run it about 50 times and make sure it passes.

http://codereview.chromium.org/6008012/diff/1/functional/omnibox.py
File functional/omnibox.py (right):

http://codereview.chromium.org/6008012/diff/1/functional/omnibox.py#newcode310
functional/omnibox.py:310: def _verifyOpenHistoryPageOption(self, search_text):
This is a misnomer. Doens't really 'verify'

Rename to: _GetHistoryPageOption

http://codereview.chromium.org/6008012/diff/1/functional/omnibox.py#newcode316
functional/omnibox.py:316: if len(matches_description) == 0:
return len(matches_description) != 0

[rohitbm, 2011-01-06 02:48:26]

Yupe, ran it for 50 times on the bot machine. It passed.
I have uploaded the code with changes.

Thanks,
Rohit

On 2011/01/06 02:09:17, Nirnimesh wrote:
> Please run it about 50 times and make sure it passes.
> 
> http://codereview.chromium.org/6008012/diff/1/functional/omnibox.py
> File functional/omnibox.py (right):
> 
> http://codereview.chromium.org/6008012/diff/1/functional/omnibox.py#newcode310
> functional/omnibox.py:310: def _verifyOpenHistoryPageOption(self,
search_text):
> This is a misnomer. Doens't really 'verify'
> 
> Rename to: _GetHistoryPageOption
Done.
> 
> http://codereview.chromium.org/6008012/diff/1/functional/omnibox.py#newcode316
> functional/omnibox.py:316: if len(matches_description) == 0:
> return len(matches_description) != 0
Done.

[Nirnimesh, 2011-01-06 22:59:37]

http://codereview.chromium.org/6008012/diff/5001/functional/omnibox.py
File functional/omnibox.py (right):

http://codereview.chromium.org/6008012/diff/5001/functional/omnibox.py#newcod...
functional/omnibox.py:310: def GetHistoryPageOption(self, search_text):
I'm sorry I meant "Got" not "Get", as in a question.

http://codereview.chromium.org/6008012/diff/5001/functional/omnibox.py#newcod...
functional/omnibox.py:311: """Verify if history page option is available or not
in the omnnibox
Fix this docstring. Remove "Verify"

[rohitbm, 2011-01-07 02:39:32]

I have uploaded the code with changes.

Thanks,
Rohit

On 2011/01/06 22:59:37, Nirnimesh wrote:
> http://codereview.chromium.org/6008012/diff/5001/functional/omnibox.py
> File functional/omnibox.py (right):
> 
>
http://codereview.chromium.org/6008012/diff/5001/functional/omnibox.py#newcod...
> functional/omnibox.py:310: def GetHistoryPageOption(self, search_text):
> I'm sorry I meant "Got" not "Get", as in a question.
Done.
> 
>
http://codereview.chromium.org/6008012/diff/5001/functional/omnibox.py#newcod...
> functional/omnibox.py:311: """Verify if history page option is available or
not
> in the omnnibox
> Fix this docstring. Remove "Verify"
Done.

[Nirnimesh, 2011-01-07 19:11:43]

LGTM. You can commit yourself now.