Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: functional/omnibox.py

Issue 6008012: Adding more verifications to recenthistorypage test (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/test/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: functional/omnibox.py
===================================================================
--- functional/omnibox.py (revision 70574)
+++ functional/omnibox.py (working copy)
@@ -307,6 +307,14 @@
matches_description = [x for x in matches if x['destination_url'] == url]
self.assertEqual(1, len(matches_description))
+ def _GotHistoryPageOption(self, search_text):
+ """Determines if omnibox returns an 'open history page' option for given
+ search text"""
+ matches = self._GetOmniboxMatchesFor(search_text)
+ matches_description = [x for x in matches if x['type'] ==
+ 'open-history-page']
+ return len(matches_description) != 0
+
def testRecentPageHistory(self):
"""Verify that omnibox shows recent history option in the visited
url list."""
@@ -314,18 +322,13 @@
sites = glob.glob(os.path.join(self.DataDir(), 'find_in_page', '*.html'))
for site in sites:
self.NavigateToURL(self.GetFileURLForPath(site))
- old_matches = self._GetOmniboxMatchesFor(search_text)
# Using max timeout as 120 seconds, since expected page only shows up
# after > 60 seconds on some machines and default timeout is less than that.
# TODO (Nirnimesh): design an api using which we can push history changes to
# omnibox results.
self.assertTrue(self.WaitUntil(
- lambda: self._GotNewMatches(len(old_matches), search_text),
+ lambda: self._GotHistoryPageOption(search_text),
timeout=120))
- matches = self._GetOmniboxMatchesFor(search_text)
- matches_description = [x for x in matches if x['type'] ==
- 'open-history-page']
- self.assertEqual(1, len(matches_description))
def _VerifyHasBookmarkResult(self, matches):
"""Verify that we have a bookmark result."""
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698