Check for circular dependencies between .gyp files....

pylib/gyp/__init__.py

 #!/usr/bin/python
 
 # Copyright (c) 2009 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import gyp.input
 import optparse
 import os.path
@@ skipping 17 matching lines @@
   extension = '.gyp'
   files = os.listdir(os.getcwd())
   build_files = []
   for file in files:
     if file[-len(extension):] == extension:
       build_files.append(file)
   return build_files
 
 
 def Load(build_files, format, default_variables={},
-         includes=[], depth='.', params={}, check=False):
+         includes=[], depth='.', params={}, check=False, circular_check=True):
   """
   Loads one or more specified build files.
   default_variables and includes will be copied before use.
   Returns the generator for the specified format and the
   data returned by loading the specified build files.
   """
   default_variables = copy.copy(default_variables)
 
   # Default variables provided by this program and its modules should be
   # named WITH_CAPITAL_LETTERS to provide a distinct "best practice" namespace,
@@ skipping 24 matching lines @@
     'path_sections':
         getattr(generator, 'generator_additional_path_sections', []),
     'extra_sources_for_rules':
         getattr(generator, 'generator_extra_sources_for_rules', []),
     'generator_supports_multiple_toolsets':
         getattr(generator, 'generator_supports_multiple_toolsets', False),
   }
 
   # Process the input specific to this generator.
   result = gyp.input.Load(build_files, default_variables, includes[:],
-                          depth, generator_input_info, check)
+                          depth, generator_input_info, check, circular_check)
   return [generator] + result
 
 def NameValueListToDict(name_value_list):
   """
   Takes an array of strings of the form 'NAME=VALUE' and creates a dictionary
   of the pairs.  If a string is simply NAME, then the value in the dictionary
   is set to True.  If VALUE can be converted to an integer, it is.
   """
   result = { }
   for item in name_value_list:
@@ skipping 163 matching lines @@
                     help='sets generator flag FLAG to VAL')
   parser.add_option('--generator-output', dest='generator_output',
                     action='store', default=None, metavar='DIR', type='path',
                     env_name='GYP_GENERATOR_OUTPUT',
                     help='puts generated build files under DIR')
   parser.add_option('--ignore-environment', dest='use_environment',
                     action='store_false', default=True, regenerate=False,
                     help='do not read options from environment variables')
   parser.add_option('--check', dest='check', action='store_true',
                     help='check format of gyp files')
+  # --no-circular-check disables the check for circular relationships between
+  # .gyp files.  These relationships should not exist, but they've only been
+  # observed to be harmful with the Xcode generator.  Chromium's .gyp files
+  # currently have some circular relationships on non-Mac platforms, so this
+  # option allows the strict behavior to be used on Macs and the lenient
+  # behavior to be used elsewhere.
+  # TODO(mark): Remove this option when http://crbug.com/35878 is fixed.
+  parser.add_option('--no-circular-check', dest='circular_check',
+                    action='store_false', default=True, regenerate=False,
+                    help="don't check for circular relationships between files")
 
   # We read a few things from ~/.gyp, so set up a var for that.
   home_vars = ['HOME']
   if sys.platform in ('cygwin', 'win32'):
     home_vars.append('USERPROFILE')
   home = None
   for home_var in home_vars:
     home = os.getenv(home_var)
     if home != None:
       break
@@ skipping 136 matching lines @@
               'generator_flags': generator_flags,
               'cwd': os.getcwd(),
               'build_files_arg': build_files_arg,
               'gyp_binary': sys.argv[0],
               'home_dot_gyp': home_dot_gyp}
 
     # Start with the default variables from the command line.
     [generator, flat_list, targets, data] = Load(build_files, format,
                                                  cmdline_default_variables,
                                                  includes, options.depth,
-                                                 params, options.check)
+                                                 params, options.check,
+                                                 options.circular_check)
 
     # TODO(mark): Pass |data| for now because the generator needs a list of
     # build files that came in.  In the future, maybe it should just accept
     # a list, and not the whole data dict.
     # NOTE: flat_list is the flattened dependency graph specifying the order
     # that targets may be built.  Build systems that operate serially or that
     # need to have dependencies defined before dependents reference them should
     # generate targets in the order specified in flat_list.
     generator.GenerateOutput(flat_list, targets, data, params)
 
   # Done
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))