Issue 5998010: Use the existing PRINTPAGERANGE rather than allocating a new one....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5998010: Use the existing PRINTPAGERANGE rather than allocating a new one.... (Closed)

Created:
9 years, 11 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use the existing PRINTPAGERANGE rather than allocating a new one. BUG=68307 TEST=Dr. Memory no longer complains. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72032

Patch Set 3 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -16 lines)			Patch
M	printing/printing_context_win.cc	View	1 2	3 chunks	+5 lines, -7 lines	0 comments	Download
M	printing/printing_context_win_unittest.cc	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	tools/valgrind/drmemory/suppressions.txt	View	1 2	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://codereview.chromium.org/5998010/diff/3001/printing/printing_context_win_unittest.cc File printing/printing_context_win_unittest.cc (left): http://codereview.chromium.org/5998010/diff/3001/printing/printing_context_win_unittest.cc#oldcode41 printing/printing_context_win_unittest.cc:41: lppd->lpPageRanges = new PRINTPAGERANGE[1]; This is not needed, since ...

9 years, 11 months ago (2011-01-05 01:34:54 UTC) #1

Timur Iskhodzhanov

I'm not familiar enough with the code but if your assumption is right, the change ...

9 years, 11 months ago (2011-01-18 12:13:02 UTC) #2

Timur Iskhodzhanov

ping? On 2011/01/18 12:13:02, Timur Iskhodzhanov wrote: > I'm not familiar enough with the code ...

9 years, 11 months ago (2011-01-19 17:36:45 UTC) #3

Lei Zhang

9 years, 11 months ago (2011-01-20 00:22:33 UTC) #4

Let me run it through a Windows try bot and make sure nothing bad happens.

Expand Messages | Collapse Messages

Issue 5998010: Use the existing PRINTPAGERANGE rather than allocating a new one.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages