Use the existing PRINTPAGERANGE rather than allocating a new one....

printing/printing_context_win_unittest.cc

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <ocidl.h>
 #include <commdlg.h>
 
 #include <string>
 
 #include "base/scoped_ptr.h"
 #include "printing/printing_test.h"
@@ skipping 19 matching lines @@
 // This is a fake PrintDlgEx implementation that sets the right fields in
 // |lppd| to trigger a bug in older revisions of PrintingContext.
 HRESULT WINAPI PrintDlgExMock(LPPRINTDLGEX lppd) {
   // The interesting bits:
   // Pretend the user hit print
   lppd->dwResultAction = PD_RESULT_PRINT;
 
   // Pretend the page range is 1-5, but since lppd->Flags does not have
   // PD_SELECTION set, this really shouldn't matter.
   lppd->nPageRanges = 1;
-  lppd->lpPageRanges = new PRINTPAGERANGE[1];

[Lei Zhang, 2011/01/05 01:34:54]

This is not needed, since we only call PrintDlgExMock() in a test where
|max_pages| is set to a dummy value > 0. Thus |lppd->lpPageRanges| is valid
already.

   lppd->lpPageRanges[0].nFromPage = 1;
   lppd->lpPageRanges[0].nToPage = 5;
 
   // Painful paperwork.
   std::wstring printer_name = PrintingContextTest::GetDefaultPrinter();
   HANDLE printer;
   if (!OpenPrinter(const_cast<wchar_t*>(printer_name.c_str()), &printer, NULL))
     return E_FAIL;
 
   scoped_array<uint8> buffer;
@@ skipping 81 matching lines @@
   context.AskUserForSettings(
       NULL,
       123,
       false,
       NewCallback(static_cast<PrintingContextTest*>(this),
                   &PrintingContextTest::PrintSettingsCallback));
   ASSERT_EQ(printing::PrintingContext::OK, result());
   printing::PrintSettings settings = context.settings();
   EXPECT_EQ(settings.ranges.size(), 0);
 }