Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5996003: Revert "Revert 69755 - Move the NPAPI files from webkit/glue/plugins to webkit/plugins/npapi" (Closed)

Created:
10 years ago by chase
Modified:
9 years, 7 months ago
Reviewers:
dmac
CC:
chromium-reviews, Paweł Hajdan Jr., jam, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, brettw
Visibility:
Public.

Description

Revert "Revert 69755 - Move the NPAPI files from webkit/glue/plugins to webkit/plugins/npapi" Manually reverting r69766, which was itself a failed revert of r69755. BUG=none TEST=none TBR=dmaclach@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1253 lines, -860 lines) Patch
M chrome/app/framework.order View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/dom_ui/plugins_ui.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/gtk/content_setting_bubble_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/hang_monitor/hung_plugin_action.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_log.h View 3 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/mock_plugin_exceptions_table_model.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/mock_plugin_exceptions_table_model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/plugin_carbon_interpose_mac.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/plugin_data_remover.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_data_remover.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/plugin_exceptions_table_model.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/plugin_exceptions_table_model.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/plugin_exceptions_table_model_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/plugin_installer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/plugin_process_host.h View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/plugin_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_service.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/plugin_service.cc View 14 chunks +26 lines, -24 lines 0 comments Download
M chrome/browser/plugin_service_browsertest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/plugin_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugin_updater.h View 3 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/plugin_updater.cc View 10 chunks +25 lines, -20 lines 0 comments Download
M chrome/browser/renderer_host/accelerated_surface_container_mac.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/accelerated_surface_container_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/buffered_resource_handler.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/renderer_host/render_message_filter.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_message_filter.cc View 6 chunks +17 lines, -15 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/table_model_array_controller_unittest.mm View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/common/chrome_plugin_lib.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/default_plugin.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/gpu_plugin.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/common/render_messages.h View 4 chunks +14 lines, -9 lines 0 comments Download
M chrome/common/render_messages.cc View 8 chunks +20 lines, -14 lines 0 comments Download
M chrome/common/render_messages_internal.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/render_messages_params.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/default_plugin/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/default_plugin/plugin_impl_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/default_plugin/plugin_impl_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/default_plugin/plugin_impl_win.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M chrome/plugin/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/chrome_plugin_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/plugin/npobject_proxy.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/plugin/npobject_stub.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/plugin/npobject_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/plugin/plugin_channel.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/plugin/plugin_interpose_util_mac.mm View 6 chunks +11 lines, -7 lines 0 comments Download
M chrome/plugin/plugin_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/plugin_thread.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/plugin/webplugin_accelerated_surface_proxy_mac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M chrome/plugin/webplugin_proxy.h View 8 chunks +15 lines, -9 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/renderer/blocked_plugin.h View 2 chunks +12 lines, -6 lines 0 comments Download
M chrome/renderer/blocked_plugin.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/renderer/pepper_devices.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/pepper_devices_browsertest.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M chrome/renderer/pepper_plugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper_scrollbar_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper_widget.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/renderer/render_process_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.h View 7 chunks +12 lines, -9 lines 0 comments Download
M chrome/renderer/render_view.cc View 10 chunks +24 lines, -22 lines 0 comments Download
M chrome/renderer/render_widget.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/renderer/render_widget.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/renderer_glue.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.h View 6 chunks +12 lines, -10 lines 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.cc View 8 chunks +20 lines, -19 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 5 chunks +11 lines, -9 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M chrome/test/plugin/plugin_test.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/glue/webkit_glue.h View 3 chunks +8 lines, -2 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 3 chunks +73 lines, -73 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/plugins/npapi/test/npapi_constants.h View 2 chunks +8 lines, -5 lines 0 comments Download
M webkit/plugins/npapi/test/npapi_constants.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/npapi_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_arguments_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_arguments_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_client.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_client.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_create_instance_in_paint.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_create_instance_in_paint.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_delete_plugin_in_stream_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_delete_plugin_in_stream_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_get_javascript_url2_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_get_javascript_url2_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_get_javascript_url_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_get_javascript_url_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_geturl_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_geturl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/test/plugin_javascript_open_popup.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_javascript_open_popup.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_new_fails_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_new_fails_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_npobject_lifetime_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_npobject_proxy_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_npobject_proxy_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_private_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_private_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_schedule_timer_test.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_schedule_timer_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_setup_test.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_setup_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_test.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_test_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_test_factory.cc View 1 chunk +17 lines, -17 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_thread_async_call_test.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_thread_async_call_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_window_size_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_window_size_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_windowed_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_windowed_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_windowless_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_windowless_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/resource.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/plugin_switches.h View 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/plugins/plugin_switches.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/url_request_info_unittest.cc View 1 chunk +249 lines, -0 lines 0 comments Download
M webkit/support/platform_support_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/support/test_webplugin_page_delegate.h View 2 chunks +8 lines, -6 lines 0 comments Download
M webkit/support/webkit_support.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M webkit/support/webkit_support_glue.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/mac/test_webview_delegate.mm View 4 chunks +6 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 6 chunks +15 lines, -12 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 6 chunks +61 lines, -59 lines 0 comments Download
M webkit/tools/test_shell/test_shell_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 4 chunks +19 lines, -20 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 4 chunks +14 lines, -13 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_gtk.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_win.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/webview_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/webview_host_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
chase
10 years ago (2010-12-20 23:42:24 UTC) #1
dmac
10 years ago (2010-12-20 23:45:58 UTC) #2 
Rubber stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698