Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6920)

Unified Diff: chrome/renderer/render_view.cc

Issue 5996003: Revert "Revert 69755 - Move the NPAPI files from webkit/glue/plugins to webkit/plugins/npapi" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/render_view.h ('k') | chrome/renderer/render_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_view.cc
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index 2c50d8ee0e7a6b42a19cdc19e88c02ea37959ffc..5dd33599af9d17b83fbe1a07271df31691935b49 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -172,18 +172,18 @@
#include "webkit/glue/image_resource_fetcher.h"
#include "webkit/glue/media/video_renderer_impl.h"
#include "webkit/glue/password_form_dom_manager.h"
-#include "webkit/glue/plugins/default_plugin_shared.h"
-#include "webkit/glue/plugins/plugin_list.h"
-#include "webkit/glue/plugins/webplugin_delegate.h"
-#include "webkit/glue/plugins/webplugin_delegate_impl.h"
-#include "webkit/glue/plugins/webplugin_impl.h"
-#include "webkit/glue/plugins/webview_plugin.h"
#include "webkit/glue/resource_fetcher.h"
#include "webkit/glue/site_isolation_metrics.h"
#include "webkit/glue/webaccessibility.h"
#include "webkit/glue/webdropdata.h"
#include "webkit/glue/webkit_glue.h"
#include "webkit/glue/webmediaplayer_impl.h"
+#include "webkit/plugins/npapi/default_plugin_shared.h"
+#include "webkit/plugins/npapi/plugin_list.h"
+#include "webkit/plugins/npapi/webplugin_delegate.h"
+#include "webkit/plugins/npapi/webplugin_delegate_impl.h"
+#include "webkit/plugins/npapi/webplugin_impl.h"
+#include "webkit/plugins/npapi/webview_plugin.h"
#include "webkit/plugins/ppapi/ppapi_webplugin_impl.h"
#if defined(OS_WIN)
@@ -842,7 +842,7 @@ void RenderView::PluginCrashed(const FilePath& plugin_path) {
WebPlugin* RenderView::CreatePluginNoCheck(WebFrame* frame,
const WebPluginParams& params) {
- WebPluginInfo info;
+ webkit::npapi::WebPluginInfo info;
bool found;
ContentSetting setting;
std::string mime_type;
@@ -2026,14 +2026,15 @@ void RenderView::OnMissingPluginStatus(
#if defined(OS_WIN)
if (!first_default_plugin_) {
// Show the InfoBar for the first available plugin.
- if (status == default_plugin::MISSING_PLUGIN_AVAILABLE) {
+ if (status == webkit::npapi::default_plugin::MISSING_PLUGIN_AVAILABLE) {
first_default_plugin_ = delegate->AsWeakPtr();
Send(new ViewHostMsg_MissingPluginStatus(routing_id_, status));
}
} else {
// Closes the InfoBar if user clicks on the plugin (instead of the InfoBar)
// to start the download/install.
- if (status == default_plugin::MISSING_PLUGIN_USER_STARTED_DOWNLOAD) {
+ if (status ==
+ webkit::npapi::default_plugin::MISSING_PLUGIN_USER_STARTED_DOWNLOAD) {
Send(new ViewHostMsg_MissingPluginStatus(routing_id_, status));
}
}
@@ -2754,7 +2755,7 @@ WebPlugin* RenderView::createPlugin(WebFrame* frame,
bool found = false;
ContentSetting plugin_setting = CONTENT_SETTING_DEFAULT;
CommandLine* cmd = CommandLine::ForCurrentProcess();
- WebPluginInfo info;
+ webkit::npapi::WebPluginInfo info;
GURL url(params.url);
std::string actual_mime_type;
Send(new ViewHostMsg_GetPluginInfo(url,
@@ -2769,8 +2770,8 @@ WebPlugin* RenderView::createPlugin(WebFrame* frame,
return NULL;
DCHECK(plugin_setting != CONTENT_SETTING_DEFAULT);
- const PluginGroup* group =
- NPAPI::PluginList::Singleton()->GetPluginGroup(info);
+ const webkit::npapi::PluginGroup* group =
+ webkit::npapi::PluginList::Singleton()->GetPluginGroup(info);
DCHECK(group != NULL);
if (cmd->HasSwitch(switches::kBlockOutdatedPlugins) &&
@@ -2789,7 +2790,7 @@ WebPlugin* RenderView::createPlugin(WebFrame* frame,
ContentSetting host_setting =
current_content_settings_.settings[CONTENT_SETTINGS_TYPE_PLUGINS];
- if (info.path.value() == kDefaultPluginLibraryName ||
+ if (info.path.value() == webkit::npapi::kDefaultPluginLibraryName ||
plugin_setting == CONTENT_SETTING_ALLOW ||
host_setting == CONTENT_SETTING_ALLOW) {
scoped_refptr<webkit::ppapi::PluginModule> pepper_module(
@@ -3939,7 +3940,7 @@ void RenderView::openFileSystem(
// webkit_glue::WebPluginPageDelegate -----------------------------------------
-webkit_glue::WebPluginDelegate* RenderView::CreatePluginDelegate(
+webkit::npapi::WebPluginDelegate* RenderView::CreatePluginDelegate(
const FilePath& file_path,
const std::string& mime_type) {
if (!PluginChannelHost::IsListening())
@@ -4007,7 +4008,7 @@ webkit_glue::WebPluginDelegate* RenderView::CreatePluginDelegate(
return pepper_plugin;
} else {
#if defined(OS_WIN) // In-proc plugins aren't supported on Linux or Mac.
- return WebPluginDelegateImpl::Create(
+ return webkit::npapi::WebPluginDelegateImpl::Create(
file_path, mime_type, gfx::NativeViewFromId(host_window_));
#else
NOTIMPLEMENTED();
@@ -4034,7 +4035,7 @@ void RenderView::WillDestroyPluginWindow(gfx::PluginWindowHandle window) {
CleanupWindowInPluginMoves(window);
}
-void RenderView::DidMovePlugin(const webkit_glue::WebPluginGeometry& move) {
+void RenderView::DidMovePlugin(const webkit::npapi::WebPluginGeometry& move) {
SchedulePluginMove(move);
}
@@ -4436,18 +4437,19 @@ WebPlugin* RenderView::CreatePepperPlugin(
pepper_module, params, pepper_delegate_.AsWeakPtr());
}
-WebPlugin* RenderView::CreateNPAPIPlugin(WebFrame* frame,
- const WebPluginParams& params,
- const FilePath& path,
- const std::string& mime_type) {
- return new webkit_glue::WebPluginImpl(
+WebPlugin* RenderView::CreateNPAPIPlugin(
+ WebFrame* frame,
+ const WebPluginParams& params,
+ const FilePath& path,
+ const std::string& mime_type) {
+ return new webkit::npapi::WebPluginImpl(
frame, params, path, mime_type, AsWeakPtr());
}
WebPlugin* RenderView::CreatePluginPlaceholder(
WebFrame* frame,
const WebPluginParams& params,
- const PluginGroup& group,
+ const webkit::npapi::PluginGroup& group,
int resource_id,
int message_id) {
// |blocked_plugin| will delete itself when the WebViewPlugin
« no previous file with comments | « chrome/renderer/render_view.h ('k') | chrome/renderer/render_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698