Issue 5996002: Add untagged double versions of Math.sin and Math.cos.

Issue 5996002: Add untagged double versions of Math.sin and Math.cos. (Closed)

Created:
10 years ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add untagged double versions of Math.sin and Math.cos. Merge classes TranscendentalCacheStub and TranscendentalCacheSSE2Stub. Committed: http://code.google.com/p/v8/source/detail?r=6083

Patch Set 5 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+179 lines, -219 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2 3 4	3 chunks	+2 lines, -4 lines	0 comments	Download
M	src/heap.h	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View	1 2 3 4	1 chunk	+10 lines, -21 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 2 3 4	5 chunks	+112 lines, -185 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 2 3 4	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 2 3 4	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3 4	3 chunks	+26 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/5996002/diff/11002/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/5996002/diff/11002/src/ia32/code-stubs-ia32.cc#newcode2481 src/ia32/code-stubs-ia32.cc:2481: // UNTAGGED cast: cast->case. http://codereview.chromium.org/5996002/diff/11002/src/ia32/code-stubs-ia32.cc#newcode2601 src/ia32/code-stubs-ia32.cc:2601: } else ...

10 years ago (2010-12-20 13:45:49 UTC) #2

William Hesse

10 years ago (2010-12-20 13:52:04 UTC) #3

http://codereview.chromium.org/5996002/diff/11002/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/5996002/diff/11002/src/ia32/code-stubs-ia32.cc...
src/ia32/code-stubs-ia32.cc:2481: // UNTAGGED cast:
On 2010/12/20 13:45:49, Lasse Reichstein wrote:
> cast->case.

Done.

http://codereview.chromium.org/5996002/diff/11002/src/ia32/code-stubs-ia32.cc...
src/ia32/code-stubs-ia32.cc:2620: __ bind(&skip_cache);
On 2010/12/20 13:45:49, Lasse Reichstein wrote:
> Does this mean that we don't cache the result in the untagged case?

We only don't cache the result in the untagged case if new space is full.  I
have a future change to ensure that a GC is called in this case.

Expand Messages | Collapse Messages