Issue 5996001: Ensure that the SSE2 TranscendentalCache stub calls GC if it runs out of memo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5996001: Ensure that the SSE2 TranscendentalCache stub calls GC if it runs out of memo... (Closed)

Created:
10 years ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Ensure that the SSE2 TranscendentalCache stub calls GC if it runs out of memory in new space. Previously, it would just use an alternate algorithm, that did not cache the result. Committed: http://code.google.com/p/v8/source/detail?r=6090

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	src/ia32/code-stubs-ia32.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

http://codereview.chromium.org/5996001/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/5996001/diff/1/src/ia32/code-stubs-ia32.cc#newcode2794 src/ia32/code-stubs-ia32.cc:2794: __ CallRuntimeSaveDoubles(Runtime::kAllocateInNewSpace); There is a Runtime::PerformGC function. It would ...

10 years ago (2010-12-17 13:47:57 UTC) #2

William Hesse

10 years ago (2010-12-21 09:46:57 UTC) #3

Change remains basically the same.  We cannot use Runtime::PerformGC because the
calling convention and required context don't fit this situation.

Expand Messages | Collapse Messages