Ensure that the SSE2 TranscendentalCache stub calls GC if it runs out of memo...

src/ia32/code-stubs-ia32.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2761 matching lines @@
   __ add(Operand(esp), Immediate(kDoubleSize));
   GenerateOperation(masm);
   __ mov(Operand(ecx, 0), ebx);
   __ mov(Operand(ecx, kIntSize), edx);
   __ mov(Operand(ecx, 2 * kIntSize), eax);
   __ fstp_d(FieldOperand(eax, HeapNumber::kValueOffset));
   __ movdbl(xmm1, FieldOperand(eax, HeapNumber::kValueOffset));
   __ Ret();
 
   __ bind(&skip_cache);
+  // Do not allocate an answer to put it in the cache
   __ sub(Operand(esp), Immediate(kDoubleSize));
   __ movdbl(Operand(esp, 0), xmm1);
   __ fld_d(Operand(esp, 0));
   GenerateOperation(masm);
   __ fstp_d(Operand(esp, 0));
   __ movdbl(xmm1, Operand(esp, 0));
   __ add(Operand(esp), Immediate(kDoubleSize));
+  // We return the value in xmm1 without adding it to the cache, but
+  // we cause a scavenging GC so that future allocations will succeed.
+  __ EnterInternalFrame();
+  __ push(Immediate(Smi::FromInt(kDoubleSize)));  // Unused aligned object.
+  __ CallRuntimeSaveDoubles(Runtime::kAllocateInNewSpace);

[Kevin Millikin (Chromium), 2010/12/17 13:47:57]

There is a Runtime::PerformGC function.  It would be more direct to call that,
if you could manage it.

+  __ LeaveInternalFrame();
   __ Ret();
 
   __ bind(&call_runtime);
   __ AllocateHeapNumber(eax, edi, no_reg, &skip_cache);
   __ movdbl(FieldOperand(eax, HeapNumber::kValueOffset), xmm1);
   __ EnterInternalFrame();
   __ push(eax);
   __ CallRuntime(RuntimeFunction(), 1);
   __ LeaveInternalFrame();
   __ movdbl(xmm1, FieldOperand(eax, HeapNumber::kValueOffset));
@@ skipping 3672 matching lines @@
   // Do a tail call to the rewritten stub.
   __ jmp(Operand(edi));
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32