Issue 5992006: Move data pack from base to app (it's just part of the resource bundle system...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5992006: Move data pack from base to app (it's just part of the resource bundle system... (Closed)

Created:
10 years ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move data pack from base to app (it's just part of the resource bundle system). TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70038

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -411 lines)			Patch
M	app/app.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	app/app_base.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	app/data_pack.h	View	6 chunks	+14 lines, -10 lines	0 comments	Download
A +	app/data_pack.cc	View	7 chunks	+10 lines, -7 lines	0 comments	Download
A +	app/data_pack_unittest.cc	View	3 chunks	+7 lines, -3 lines	0 comments	Download
M	app/resource_bundle.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	app/resource_bundle.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	app/resource_bundle_posix.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	app/resource_bundle_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/base.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/base.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	base/data/data_pack_unittest/sample.pak	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	base/data_pack.h	View	1 chunk	+0 lines, -62 lines	0 comments	Download
D	base/data_pack.cc	View	1 chunk	+0 lines, -216 lines	0 comments	Download
D	base/data_pack_unittest.cc	View	1 chunk	+0 lines, -73 lines	0 comments	Download
M	chrome/browser/themes/browser_theme_pack.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/themes/browser_theme_pack.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/tools/mac_helpers/infoplist_strings_util.mm	View	5 chunks	+9 lines, -9 lines	0 comments	Download
M	webkit/support/platform_support_gtk.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/support/platform_support_mac.mm	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_mac.mm	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages